From: Ian Abbott <abbotti@mev.co.uk>
To: Conrad Gomes <conrad.s.j.gomes@gmail.com>,
Ian Abbott <ian.abbott@mev.co.uk>,
"hsweeten@visionengravers.com" <hsweeten@visionengravers.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"joe@perches.com" <joe@perches.com>
Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 0/7] Staging: comedi: fix coding style issues in unioxx5.c
Date: Mon, 25 Nov 2013 10:13:06 +0000 [thread overview]
Message-ID: <529322B2.4090702@mev.co.uk> (raw)
In-Reply-To: <1385063878-10267-1-git-send-email-conrad.s.j.gomes@gmail.com>
On 2013-11-21 19:57, Conrad Gomes wrote:
> This series contains various fixes to coding style issues in unioxx5.c
> found by checkpatch.pl and due to the usage of pr_err instead of the
> preferred dev_err type functions for device drivers.
>
> Conrad Gomes (7):
> Staging: comedi: fix line over 80 character warning in unioxx5.c
> Staging: comedi: fix line over 80 character warning in unioxx5.c
> Staging: comedi: change printk to dev_err/dev_dbg in unioxx5.c
> Staging: comedi: change pr_err to dev_err in __unioxx5_analog_read
> Staging: comedi: change pr_err to dev_err in __unioxx5_digital_write
> Staging: comedi: change pr_err to dev_err in __unioxx5_analog_write
> Staging: comedi: remove MACRO pr_fmt in unioxx5.c
>
> drivers/staging/comedi/drivers/unioxx5.c | 50 ++++++++++++++++++------------
> 1 file changed, 31 insertions(+), 19 deletions(-)
Looks okay!
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
prev parent reply other threads:[~2013-11-25 10:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 19:57 [PATCH V2 0/7] Staging: comedi: fix coding style issues in unioxx5.c Conrad Gomes
2013-11-21 19:57 ` [PATCH V2 1/7] Staging: comedi: fix line over 80 character warning " Conrad Gomes
2013-11-21 19:57 ` [PATCH V2 2/7] " Conrad Gomes
2013-11-21 19:57 ` [PATCH V2 3/7] Staging: comedi: change printk to dev_err/dev_dbg " Conrad Gomes
2013-11-21 19:57 ` [PATCH V2 4/7] Staging: comedi: change pr_err to dev_err in __unioxx5_analog_read Conrad Gomes
2013-11-21 19:57 ` [PATCH V2 5/7] Staging: comedi: change pr_err to dev_err in __unioxx5_digital_write Conrad Gomes
2013-11-21 19:57 ` [PATCH V2 6/7] Staging: comedi: change pr_err to dev_err in __unioxx5_analog_write Conrad Gomes
2013-11-21 19:57 ` [PATCH V2 7/7] Staging: comedi: remove MACRO pr_fmt in unioxx5.c Conrad Gomes
2013-11-25 10:13 ` Ian Abbott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529322B2.4090702@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=conrad.s.j.gomes@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=ian.abbott@mev.co.uk \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.