Re: [Qemu-devel] [PATCH v3 07/19] vpc, vhdx: add get_info

[Peter Lieven <pl@kamp.de>]

On 22.11.2013 13:39, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   block/vhdx.c | 10 ++++++++++
>   block/vpc.c  | 14 ++++++++++++++
>   2 files changed, 24 insertions(+)
>
> diff --git a/block/vhdx.c b/block/vhdx.c
> index 7d1af96..ed6fa53 100644
> --- a/block/vhdx.c
> +++ b/block/vhdx.c
> @@ -1043,6 +1043,15 @@ static void vhdx_block_translate(BDRVVHDXState *s, int64_t sector_num,
>   }
>   
>   
> +static int vhdx_get_info(BlockDriverState *bs, BlockDriverInfo *bdi)
> +{
> +    BDRVVHDXState *s = bs->opaque;
> +
> +    bdi->cluster_size = s->block_size;
> +
> +    return 0;
> +}
> +
>   
>   static coroutine_fn int vhdx_co_readv(BlockDriverState *bs, int64_t sector_num,
>                                         int nb_sectors, QEMUIOVector *qiov)
> @@ -1885,6 +1894,7 @@ static BlockDriver bdrv_vhdx = {
>       .bdrv_co_readv          = vhdx_co_readv,
>       .bdrv_co_writev         = vhdx_co_writev,
>       .bdrv_create            = vhdx_create,
> +    .bdrv_get_info          = vhdx_get_info,
>   
>       .create_options         = vhdx_create_options,
>   };
> diff --git a/block/vpc.c b/block/vpc.c
> index 577cc45..551876f 100644
> --- a/block/vpc.c
> +++ b/block/vpc.c
> @@ -455,6 +455,18 @@ fail:
>       return -1;
>   }
>   
> +static int vpc_get_info(BlockDriverState *bs, BlockDriverInfo *bdi)
> +{
> +    BDRVVPCState *s = (BDRVVPCState *)bs->opaque;
> +    VHDFooter *footer = (VHDFooter *) s->footer_buf;
> +
> +    if (cpu_to_be32(footer->type) != VHD_FIXED) {
> +        bdi->cluster_size = s->block_size;
> +    }
> +
> +    return 0;
> +}
> +
>   static int vpc_read(BlockDriverState *bs, int64_t sector_num,
>                       uint8_t *buf, int nb_sectors)
>   {
> @@ -857,6 +869,8 @@ static BlockDriver bdrv_vpc = {
>       .bdrv_read              = vpc_co_read,
>       .bdrv_write             = vpc_co_write,
>   
> +    .bdrv_get_info          = vpc_get_info,
> +
>       .create_options         = vpc_create_options,
>       .bdrv_has_zero_init     = vpc_has_zero_init,
>   };
Reviewed-by: Peter Lieven <pl@kamp.de>