From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mm: nobootmem: avoid type warning about alignment value
Date: Mon, 25 Nov 2013 08:57:54 -0500 [thread overview]
Message-ID: <52935762.1080409@ti.com> (raw)
In-Reply-To: <529217C7.6030304@cogentembedded.com>
On Sunday 24 November 2013 10:14 AM, Sergei Shtylyov wrote:
> Hello.
>
> On 24-11-2013 3:28, Santosh Shilimkar wrote:
>
>> Building ARM with NO_BOOTMEM generates below warning. Using min_t
>
> Where is that below? :-)
>
Damn.. Posted a wrong version of the patch ;-(
Here is the one with warning message included.
>From 571dfdf4cf8ac7dfd50bd9b7519717c42824f1c3 Mon Sep 17 00:00:00 2001
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
Date: Sat, 23 Nov 2013 18:16:50 -0500
Subject: [PATCH] mm: nobootmem: avoid type warning about alignment value
Building ARM with NO_BOOTMEM generates below warning.
mm/nobootmem.c: In function ?__free_pages_memory?:
mm/nobootmem.c:88:11: warning: comparison of distinct pointer types lacks a cast
Using min_t to find the correct alignment avoids the warning.
Cc: Tejun Heo <tj@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
---
mm/nobootmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/nobootmem.c b/mm/nobootmem.c
index 2c254d3..8954e43 100644
--- a/mm/nobootmem.c
+++ b/mm/nobootmem.c
@@ -85,7 +85,7 @@ static void __init __free_pages_memory(unsigned long start, unsigned long end)
int order;
while (start < end) {
- order = min(MAX_ORDER - 1UL, __ffs(start));
+ order = min_t(size_t, MAX_ORDER - 1UL, __ffs(start));
while (start + (1UL << order) > end)
order--;
--
1.7.9.5
WARNING: multiple messages have this Message-ID (diff)
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: linux-kernel@vger.kernel.org, Tejun Heo <tj@kernel.org>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] mm: nobootmem: avoid type warning about alignment value
Date: Mon, 25 Nov 2013 08:57:54 -0500 [thread overview]
Message-ID: <52935762.1080409@ti.com> (raw)
In-Reply-To: <529217C7.6030304@cogentembedded.com>
On Sunday 24 November 2013 10:14 AM, Sergei Shtylyov wrote:
> Hello.
>
> On 24-11-2013 3:28, Santosh Shilimkar wrote:
>
>> Building ARM with NO_BOOTMEM generates below warning. Using min_t
>
> Where is that below? :-)
>
Damn.. Posted a wrong version of the patch ;-(
Here is the one with warning message included.
WARNING: multiple messages have this Message-ID (diff)
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: <linux-kernel@vger.kernel.org>, Tejun Heo <tj@kernel.org>,
<linux-mm@kvack.org>, Andrew Morton <akpm@linux-foundation.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] mm: nobootmem: avoid type warning about alignment value
Date: Mon, 25 Nov 2013 08:57:54 -0500 [thread overview]
Message-ID: <52935762.1080409@ti.com> (raw)
In-Reply-To: <529217C7.6030304@cogentembedded.com>
On Sunday 24 November 2013 10:14 AM, Sergei Shtylyov wrote:
> Hello.
>
> On 24-11-2013 3:28, Santosh Shilimkar wrote:
>
>> Building ARM with NO_BOOTMEM generates below warning. Using min_t
>
> Where is that below? :-)
>
Damn.. Posted a wrong version of the patch ;-(
Here is the one with warning message included.
>From 571dfdf4cf8ac7dfd50bd9b7519717c42824f1c3 Mon Sep 17 00:00:00 2001
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
Date: Sat, 23 Nov 2013 18:16:50 -0500
Subject: [PATCH] mm: nobootmem: avoid type warning about alignment value
Building ARM with NO_BOOTMEM generates below warning.
mm/nobootmem.c: In function ‘__free_pages_memory’:
mm/nobootmem.c:88:11: warning: comparison of distinct pointer types lacks a cast
Using min_t to find the correct alignment avoids the warning.
Cc: Tejun Heo <tj@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
---
mm/nobootmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/nobootmem.c b/mm/nobootmem.c
index 2c254d3..8954e43 100644
--- a/mm/nobootmem.c
+++ b/mm/nobootmem.c
@@ -85,7 +85,7 @@ static void __init __free_pages_memory(unsigned long start, unsigned long end)
int order;
while (start < end) {
- order = min(MAX_ORDER - 1UL, __ffs(start));
+ order = min_t(size_t, MAX_ORDER - 1UL, __ffs(start));
while (start + (1UL << order) > end)
order--;
--
1.7.9.5
next prev parent reply other threads:[~2013-11-25 13:57 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-23 23:28 [PATCH] mm: nobootmem: avoid type warning about alignment value Santosh Shilimkar
2013-11-23 23:28 ` Santosh Shilimkar
2013-11-23 23:28 ` Santosh Shilimkar
2013-11-24 15:14 ` Sergei Shtylyov
2013-11-24 15:14 ` Sergei Shtylyov
2013-11-24 15:14 ` Sergei Shtylyov
2013-11-25 13:57 ` Santosh Shilimkar [this message]
2013-11-25 13:57 ` Santosh Shilimkar
2013-11-25 13:57 ` Santosh Shilimkar
2013-11-25 15:56 ` Tejun Heo
2013-11-25 15:56 ` Tejun Heo
2013-11-25 15:56 ` Tejun Heo
2013-12-10 0:39 ` Santosh Shilimkar
2013-12-10 0:39 ` Santosh Shilimkar
2013-12-10 0:39 ` Santosh Shilimkar
2013-12-10 0:50 ` Andrew Morton
2013-12-10 0:50 ` Andrew Morton
2013-12-10 0:50 ` Andrew Morton
2013-12-10 0:54 ` Russell King - ARM Linux
2013-12-10 0:54 ` Russell King - ARM Linux
2013-12-10 0:54 ` Russell King - ARM Linux
2013-12-10 1:02 ` Santosh Shilimkar
2013-12-10 1:02 ` Santosh Shilimkar
2013-12-10 1:02 ` Santosh Shilimkar
2014-01-12 10:59 ` Russell King - ARM Linux
2014-01-12 10:59 ` Russell King - ARM Linux
2014-01-12 10:59 ` Russell King - ARM Linux
2014-01-12 15:42 ` Santosh Shilimkar
2014-01-12 15:42 ` Santosh Shilimkar
2014-01-12 15:42 ` Santosh Shilimkar
2014-01-12 15:46 ` Santosh Shilimkar
2014-01-12 15:46 ` Santosh Shilimkar
2014-01-12 15:46 ` Santosh Shilimkar
2014-01-13 12:37 ` Russell King - ARM Linux
2014-01-13 12:37 ` Russell King - ARM Linux
2014-01-13 12:37 ` Russell King - ARM Linux
2014-01-13 14:27 ` Santosh Shilimkar
2014-01-13 14:27 ` Santosh Shilimkar
2014-01-13 14:27 ` Santosh Shilimkar
2014-01-13 23:31 ` Andrew Morton
2014-01-13 23:31 ` Andrew Morton
2014-01-13 23:31 ` Andrew Morton
2014-01-13 23:33 ` Russell King - ARM Linux
2014-01-13 23:33 ` Russell King - ARM Linux
2014-01-13 23:33 ` Russell King - ARM Linux
2014-01-13 23:41 ` Santosh Shilimkar
2014-01-13 23:41 ` Santosh Shilimkar
2014-01-13 23:41 ` Santosh Shilimkar
2014-01-15 3:46 ` Nicolas Pitre
2014-01-15 3:46 ` Nicolas Pitre
2014-01-15 3:46 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52935762.1080409@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.