From: George Dunlap <george.dunlap@eu.citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Keir Fraser <keir@xen.org>,
Ian Campbell <Ian.Campbell@citrix.com>,
Jan Beulich <JBeulich@suse.com>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [Patch v3 0/2] Remove figlet from the source tree
Date: Mon, 25 Nov 2013 14:41:23 +0000 [thread overview]
Message-ID: <52936193.4080602@eu.citrix.com> (raw)
In-Reply-To: <21139.24779.602347.49706@mariner.uk.xensource.com>
On 11/25/2013 02:38 PM, Ian Jackson wrote:
> George Dunlap writes ("Re: [Xen-devel] [Patch v3 0/2] Remove figlet from the source tree"):
>> On 11/25/2013 11:00 AM, Andrew Cooper wrote:
>>> George:
>>> This is purely a build change, so I request that it be included for 4.4
>> It's not purely a build change -- figlet is not installed by default on
>> a number of distros (Ubuntu didn't have it); and on those systems, this
>> will silently change remove the figlet-like lettering from boot.
> I agree with these criticisms of Andrew's claims for the patch.
>
> But I think the inclusion of a fork of figlet in our tree is totally
> crazy (and hence a bug). I wouldn't want to introduce this patch
> without a release ack but I think the release ack should be granted.
If you read to the end, you'll see that it was. :-)
-George
next prev parent reply other threads:[~2013-11-25 14:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 11:00 [Patch v3 0/2] Remove figlet from the source tree Andrew Cooper
2013-11-25 11:00 ` [Patch v3 1/2] xen/build: Use a distro version of figlet Andrew Cooper
2013-11-25 11:21 ` [Patch v3 0/2] Remove figlet from the source tree Ian Campbell
2013-11-25 11:23 ` Andrew Cooper
2013-11-25 12:21 ` George Dunlap
2013-11-25 12:25 ` Ian Campbell
2013-11-25 14:38 ` Ian Jackson
2013-11-25 19:45 ` Keir Fraser
2013-11-26 1:25 ` Matthew Daley
2013-11-26 8:35 ` Ian Campbell
2013-11-29 10:43 ` Ian Campbell
2013-11-29 20:15 ` Keir Fraser
2013-12-02 14:11 ` Ian Campbell
2013-11-25 14:38 ` Ian Jackson
2013-11-25 14:41 ` George Dunlap [this message]
2013-11-25 16:35 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52936193.4080602@eu.citrix.com \
--to=george.dunlap@eu.citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.