From mboxrd@z Thu Jan 1 00:00:00 1970 From: Clemens Ladisch Subject: Re: [alsa-devel] [PATCH 03/17] firewire-lib: Add 'direction' member to 'amdtp_stream' structure Date: Mon, 25 Nov 2013 16:27:08 +0100 Message-ID: <52936C4C.9030800@ladisch.de> References: <1385186884-8259-1-git-send-email-o-takashi@sakamocchi.jp> <1385186884-8259-4-git-send-email-o-takashi@sakamocchi.jp> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1385186884-8259-4-git-send-email-o-takashi@sakamocchi.jp> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux1394-devel-bounces@lists.sourceforge.net To: Takashi Sakamoto , tiwai@suse.de, perex@perex.cz Cc: alsa-devel@alsa-project.org, linux1394-devel@lists.sourceforge.net, ffado-devel@lists.sourceforge.net List-Id: alsa-devel@alsa-project.org Takashi Sakamoto wrote: > This patch adds 'direction' member to amdtp_stream structure to indicate its > direction. > +++ b/sound/firewire/amdtp.h > +enum amdtp_stream_direction { > + AMDTP_RECEIVE_STREAM = 0, > + AMDTP_TRANSMIT_STREAM > +}; We have two FireWire nodes, the PC and the audio device. Both streams are transmitted by a node and received by a node, so these names does not actually specify a direction. The DMA API uses names like DMA_FROM/TO_DEVICE for this. Alternatively, you could use something like PLAYBACK/CAPTURE. Regards, Clemens ------------------------------------------------------------------------------ Shape the Mobile Experience: Free Subscription Software experts and developers: Be at the forefront of tech innovation. Intel(R) Software Adrenaline delivers strategic insight and game-changing conversations that shape the rapidly evolving mobile landscape. Sign up now. http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk