From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
Jiri Kosina <jkosina@suse.cz>
Cc: Jean Delvare <khali@linux-fr.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Jerome Blin <jerome.blin@intel.com>
Subject: Re: [PATCH] HID: i2c-hid: disable interrupt on suspend
Date: Mon, 25 Nov 2013 10:41:57 -0500 [thread overview]
Message-ID: <52936FC5.3060905@redhat.com> (raw)
In-Reply-To: <1384342458-5551-1-git-send-email-mika.westerberg@linux.intel.com>
On 13/11/13 06:34, Mika Westerberg wrote:
> When an I2C HID device is powered of during system sleep, as a result of
> removing its power resources (by the ACPI core) the interrupt line might go
> low as well. This results inadvertent interrupt and wakes the system from
> sleep immediately.
>
> To prevent this we disable the device interrupt in the drivers suspend
> method and enable it on resume. The device can still wake the system up if
> it is wake capable (this also means that not all of its power will be
> removed to keep the interrupt line high).
>
> Reported-by: Jerome Blin <jerome.blin@intel.com>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
Jiri, just FYI, I still do not have any final consumer ready i2c-hid
hardware. So I can not test/debug anything related to the suspend-resume.
If Mika tested it properly (which I expect), you may consider pulling
this one.
Cheers,
Benjamin
next prev parent reply other threads:[~2013-11-25 15:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 11:34 [PATCH] HID: i2c-hid: disable interrupt on suspend Mika Westerberg
2013-11-25 15:41 ` Benjamin Tissoires [this message]
2013-11-25 22:18 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52936FC5.3060905@redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=jerome.blin@intel.com \
--cc=jkosina@suse.cz \
--cc=khali@linux-fr.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.