All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Peter De Schrijver
	<pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	Thierry Reding
	<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Mike Turquette
	<mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 1/5] clk: tegra: Fix clock rate computation
Date: Mon, 25 Nov 2013 10:16:04 -0700	[thread overview]
Message-ID: <529385D4.6040901@wwwdotorg.org> (raw)
In-Reply-To: <20131125140910.GI26617-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>

On 11/25/2013 07:09 AM, Peter De Schrijver wrote:
> On Mon, Nov 18, 2013 at 04:11:35PM +0100, Thierry Reding wrote:
>> The PLL output frequency is multiplied during the P-divider computation,
>> so it needs to be divided by the P-divider again before returning.
>>
>> This fixes an issue where clk_round_rate() would return the multiplied
>> frequency instead of the real one after the P-divider.
>>
> 
> Series Acked-by: Peter De Schrijver <pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> I will squash the Tegra124 fixes in the Tegra124 series.

BTW, as a maintainer of some code, you usually do one of:

a) Apply the patch yourself.

b) Ack the patch for someone else to apply.

It's unusual to do both, unless there's some confusion which tree the
patch will go through, so you do e.g. (b) first then later find out that
(a) was more correct, or vice-versa.

Also, in the past I've been asked to make sure that all ARM-related
patches go to the main ARM list as well as the Tegra-specific list, to
make sure they get full visibility.

      parent reply	other threads:[~2013-11-25 17:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-18 15:11 [PATCH 1/5] clk: tegra: Fix clock rate computation Thierry Reding
     [not found] ` <1384787499-26994-1-git-send-email-treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-11-18 15:11   ` [PATCH 2/5] clk: tegra: Initialize DSI low-power clocks Thierry Reding
2013-11-18 15:11   ` [PATCH 3/5] clk: tegra: add locking to periph clks Thierry Reding
2013-11-18 15:11   ` [PATCH 4/5] clk: tegra: add TEGRA_PERIPH_NO_GATE Thierry Reding
2013-11-18 15:11   ` [PATCH 5/5] clk: tegra: rework sor0 clock for Tegra124 Thierry Reding
2013-11-25 14:09   ` [PATCH 1/5] clk: tegra: Fix clock rate computation Peter De Schrijver
     [not found]     ` <20131125140910.GI26617-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>
2013-11-25 17:16       ` Stephen Warren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=529385D4.6040901@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.