From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52212) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vkzwq-0007Nb-9y for qemu-devel@nongnu.org; Mon, 25 Nov 2013 12:27:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vkzwh-00040u-Sj for qemu-devel@nongnu.org; Mon, 25 Nov 2013 12:27:48 -0500 Received: from [2a03:4000:1::4e2f:c7ac:d] (port=43686 helo=v220110690675601.yourvserver.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vkzwh-00040l-Ln for qemu-devel@nongnu.org; Mon, 25 Nov 2013 12:27:39 -0500 Message-ID: <52938879.1020102@weilnetz.de> Date: Mon, 25 Nov 2013 18:27:21 +0100 From: Stefan Weil MIME-Version: 1.0 References: <20131124095239.GA30786@redhat.com> <1385298244.2177.25.camel@localhost.localdomain> <20131124134240.GA9769@redhat.com> <5292052B.6010508@weilnetz.de> <20131124153958.GA10407@redhat.com> <20131124164812.GA10532@redhat.com> <5292687A.4030305@weilnetz.de> <20131125112635.GA31893@redhat.com> <1385387699.4001.7.camel@localhost.localdomain> In-Reply-To: <1385387699.4001.7.camel@localhost.localdomain> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] configure: make it possible to disable IASL List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum , "Michael S. Tsirkin" Cc: Peter Maydell , Anthony Liguori , qemu-devel@nongnu.org, Stefan Hajnoczi , Paolo Bonzini , Richard Henderson Am 25.11.2013 14:54, schrieb Marcel Apfelbaum: > On Mon, 2013-11-25 at 13:26 +0200, Michael S. Tsirkin wrote: >> On Sun, Nov 24, 2013 at 09:58:34PM +0100, Stefan Weil wrote: >>>>>> --iasl=false works without further modifications (because test "false >>>>>> -h" works and returns false). It also looks more natural than --iasl=. >>>>>> >>>>>> Cheers, Stefan >>>>> It seems that some people try --iasl= as the more natural way >>>>> to do this. It's not documented that a failing iasl will >>>>> cause a fall-back and I'd rather document an explicit option >>>>> than making it fail. >>>> I'm also curious why would you say =false is natural: >>>> it's a string option not a boolean one. >>>> >>> 'false' is a string here, namely the name of the executable which is >>> normally found at /bin/false. >>> It takes any number of parameters and always returns 1 (which is boolean >>> false >>> in shell conventions). >>> >>> You could also write --iasl=/bin/false. >>> >>> I suggest this kind of patch: >>> >>> echo " --iasl=IASL use ACPI compiler IASL [$iasl]" >>> +echo " iasl=false disables the ACPI compiler" >> It's still not a natural interface. >> >> It works by chance because we run iasl and test the return code, >> but we don't have to. >> For example, a reasonable implementation might produce >> an error if the user-specified iasl fails, breaking this hack. >> >> Interfaces should not follow implementation. >> If you don't want iasl a reasonable syntax is '' or >> --disable-iasl. > +1 on --disable-iasl > > Marcel I also prefer --disable-iasl because that's the usual QEMU way how to disable features. Cheers, Stefan