From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@kernel.org>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
alsa-devel@alsa-project.org,
Rajeev Kumar <rajeev-dlh.kumar@st.com>,
Ryan Mallon <rmallon@gmail.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Liam Girdwood <lgirdwood@gmail.com>, Timur Tabi <timur@tabi.org>,
H Hartley Sweeten <hsweeten@visionengravers.com>,
Bo Shen <voice.shen@atmel.com>,
Markus Pargmann <mpa@pengutronix.de>,
Shawn Guo <shawn.guo@linaro.org>
Subject: Re: [PATCH 1/6] ASoC: Add resource managed snd_dmaengine_pcm_register()
Date: Mon, 25 Nov 2013 18:42:56 +0100 [thread overview]
Message-ID: <52938C20.5030906@metafoo.de> (raw)
In-Reply-To: <20131125171922.GO14725@sirena.org.uk>
On 11/25/2013 06:19 PM, Mark Brown wrote:
> On Sun, Nov 24, 2013 at 02:20:57PM +0100, Lars-Peter Clausen wrote:
>
>> ---
>> include/sound/dmaengine_pcm.h | 4 ++++
>> sound/soc/soc-generic-dmaengine-pcm.c | 36 +++++++++++++++++++++++++++++++++++
>
> Please put the code in soc-devres.c. Otherwise this looks good, thanks!
>
I didn't put it there because it has a dependency on
SND_SOC_GENERIC_DMAENGINE_PCM. Sothe options were to either add ifdefery to
soc-devres.c or to put the managed function in soc-generic-dmaengine-pcm.c.
- Lars
next prev parent reply other threads:[~2013-11-25 17:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-24 13:20 [PATCH 1/6] ASoC: Add resource managed snd_dmaengine_pcm_register() Lars-Peter Clausen
2013-11-24 13:20 ` [PATCH 2/6] ASoC: atmel: Use devm_snd_dmaengine_pcm_register() Lars-Peter Clausen
2013-11-25 10:36 ` Bo Shen
2013-11-25 10:41 ` Lars-Peter Clausen
2013-11-25 11:18 ` Lars-Peter Clausen
2013-11-24 13:20 ` [PATCH 3/6] ASoC: ep93xx: " Lars-Peter Clausen
2013-11-24 13:21 ` [PATCH 4/6] ASoC: fsl: " Lars-Peter Clausen
2013-11-24 13:21 ` [PATCH 5/6] ASoC: spear: Use devm_snd_dmaengine_pcm_register Lars-Peter Clausen
2013-11-25 4:14 ` Rajeev kumar
2013-11-24 13:21 ` [PATCH 6/6] ASoC: mxs: Use devm_snd_dmaengine_pcm_register() Lars-Peter Clausen
2013-11-25 17:19 ` [PATCH 1/6] ASoC: Add resource managed snd_dmaengine_pcm_register() Mark Brown
2013-11-25 17:42 ` Lars-Peter Clausen [this message]
2013-11-25 18:23 ` Mark Brown
2013-11-25 19:31 ` Lars-Peter Clausen
-- strict thread matches above, loose matches on Subject: below --
2013-11-28 7:50 Lars-Peter Clausen
2013-11-28 13:36 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52938C20.5030906@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=fabio.estevam@freescale.com \
--cc=hsweeten@visionengravers.com \
--cc=lgirdwood@gmail.com \
--cc=mpa@pengutronix.de \
--cc=nicolas.ferre@atmel.com \
--cc=rajeev-dlh.kumar@st.com \
--cc=rmallon@gmail.com \
--cc=shawn.guo@linaro.org \
--cc=timur@tabi.org \
--cc=voice.shen@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.