All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] lm_sensors, hwmon, conky
Date: Mon, 25 Nov 2013 21:15:48 +0000	[thread overview]
Message-ID: <5293BE04.4060707@roeck-us.net> (raw)
In-Reply-To: <CABfEahBWGnHRAPGXh1yao02OCGRjRFwKw=T4QSrXn1BKb7QyNA@mail.gmail.com>

On 11/25/2013 12:02 PM, Patrick... wrote:
> Using hwmon to config conky.
> At reboot the info from hwmon appears in different hwmon
> directories.   Consequently, conky reads the wrong info into
> it's output.
>
> Is this an unreported bug or ?
>
> Please advise.
>

Hi,

unfortunately, you don't provide enough information to really enable us to help.

 From looking into the conky source, I am making the assumption that
you see the problem when booting kernel version 3.13-rc1. Of course,
that is just a wild guess.

conky wrongly assumes that sensor attributes are available in directory
/sys/class/hwmon/hwmonX/device. That assumption is wrong; attributes
can also be in /sys/class/hwmon/hwmonX directly. Several existing drivers
implement this scheme already and thus never worked with conky.
Starting with kernel version 3.13, several drivers have been converted
to attach sysfs attributes to the hwmon device and no longer to its
parent device. Going forward, more drivers will be converted to the new scheme.

Oddly enough, conky also searches through i2c and platform device directories
when looking for hwmon attributes. That is really not a good idea either.
It may work today, but there is no guarantee that it will work tomorrow.

conky should only look in /sys/class/hwmon/hwmonX and /sys/class/hwmon/hwmonX/device
for hwmon attributes. It can select the correct directory by searching for
the mandatory 'name' attribute. Of couse, an even better solution would
be to use libsensors to access hwmon attributes.

Thanks,
Guenter


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  reply	other threads:[~2013-11-25 21:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-25 20:02 [lm-sensors] lm_sensors, hwmon, conky Patrick...
2013-11-25 21:15 ` Guenter Roeck [this message]
2013-11-25 22:56 ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5293BE04.4060707@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.