From: David Daney <ddaney.cavm@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>, Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mips: Fix build error seen in some configurations
Date: Mon, 25 Nov 2013 16:09:52 -0800 [thread overview]
Message-ID: <5293E6D0.3050604@gmail.com> (raw)
In-Reply-To: <1385421660-5608-1-git-send-email-linux@roeck-us.net>
On 11/25/2013 03:21 PM, Guenter Roeck wrote:
> The following build error is seen if CONFIG_32BIT is undefined,
> CONFIG_64BIT is defined, and CONFIG_MIPS32_O32 is undefined.
>
> asm/syscall.h: In function 'mips_get_syscall_arg':
> arch/mips/include/asm/syscall.h:32:16: error: unused variable 'usp' [-Werror=unused-variable]
> cc1: all warnings being treated as errors
>
> Fixes: c0ff3c53d4f9 ('MIPS: Enable HAVE_ARCH_TRACEHOOK')
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: David Daney <david.daney@cavium.com>
> ---
> arch/mips/include/asm/syscall.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/include/asm/syscall.h b/arch/mips/include/asm/syscall.h
> index 81c8913..33e8dbf 100644
> --- a/arch/mips/include/asm/syscall.h
> +++ b/arch/mips/include/asm/syscall.h
> @@ -29,7 +29,7 @@ static inline long syscall_get_nr(struct task_struct *task,
> static inline unsigned long mips_get_syscall_arg(unsigned long *arg,
> struct task_struct *task, struct pt_regs *regs, unsigned int n)
> {
> - unsigned long usp = regs->regs[29];
> + unsigned long usp __maybe_unused = regs->regs[29];
>
> switch (n) {
> case 0: case 1: case 2: case 3:
>
prev parent reply other threads:[~2013-11-26 0:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 23:21 [PATCH] mips: Fix build error seen in some configurations Guenter Roeck
2013-11-26 0:09 ` David Daney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5293E6D0.3050604@gmail.com \
--to=ddaney.cavm@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux@roeck-us.net \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.