From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/5] fs/custom: generate complete, partition-based device images
Date: Tue, 26 Nov 2013 09:12:06 +0100 [thread overview]
Message-ID: <529457D6.8060700@mind.be> (raw)
In-Reply-To: <20131125230340.GC3435@free.fr>
On 26/11/13 00:03, Yann E. MORIN wrote:
> Arnout, All,
>
> On 2013-11-25 23:56 +0100, Arnout Vandecappelle spake thusly:
>> On 25/11/13 23:45, Yann E. MORIN wrote:
>>> Arnout, All,
>>>
>>> On 2013-11-25 23:27 +0100, Arnout Vandecappelle spake thusly:
>>>> On 25/11/13 20:05, Yann E. MORIN wrote:
>>>>> Arnout,
>>>>>
>>>>> On 2013-11-25 10:31 +0100, Arnout Vandecappelle spake thusly:
>> [snip]
>>>> Anyway, I think it should be:
>>>>
>>>> BUILD_DIR=$(BUILD_DIR) fs/custom/genimages \
>>>> '$(call qstrip,$(BR2_TARGET_ROOTFS_CUSTOM_PARTITION_TABLE))'
>>>
>>> I'm using double quotes here, now, instead of single quotes.
>>> Otherwise, consider it changed. Thanks!
>>
>> With double quotes, it will not actually be quoted because the
>> ROOTFS_$(2)_CMD use adds another level of double quotes and they cancel out.
>
> Yes, I was again too fast to reply: I'm using \"$(BLABLA)\"
>
> My reasoning is I want varuable to be expanded, like in:
> BR2_TARGET_ROOTFS_CUSTOM_PARTITION_TABLE="$(TOPDIR)/board/raspberrypi/partitions"
You do know that make doesn't interpret quotes or backslashes? So the
\" construct is passed verbatim to the shell. The $(...) on the other
hand is always expanded, except when quoted by doubling the $$.
Regards,
Arnout
>
> But since $(TOPDIR) is a Makefile constrcut, the shell won't expand it,
> so it must be make expanding it (since it is working).
>
> I'll try single quotes, since they look better.
>
> Regards,
> Yann E. MORIN.
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2013-11-26 8:12 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 22:50 [Buildroot] [RFC] Introduce the 'genimages' infrastructure Yann E. MORIN
2013-11-22 22:50 ` [Buildroot] [PATCH 1/5] package/rpi-firmware: only install one firmware file Yann E. MORIN
2013-11-24 9:04 ` Arnout Vandecappelle
2013-11-22 22:50 ` [Buildroot] [PATCH 2/5] package/rpi-firmware: add option to install firmware files in target/boot/ Yann E. MORIN
2013-11-28 20:11 ` Thomas Petazzoni
2013-11-28 20:55 ` Yann E. MORIN
2013-11-29 8:00 ` Jeremy Rosen
2013-11-29 8:09 ` Yann E. MORIN
2013-11-29 8:27 ` Thomas Petazzoni
2013-11-29 19:01 ` Yann E. MORIN
2013-12-01 0:59 ` Arnout Vandecappelle
2013-12-01 14:10 ` Yann E. MORIN
2013-11-22 22:50 ` [Buildroot] [PATCH 3/5] package/rpi-firmware: move to bootloaders menu Yann E. MORIN
2013-11-22 22:55 ` Yann E. MORIN
2013-11-28 20:08 ` Thomas Petazzoni
2013-11-28 21:16 ` Yann E. MORIN
2013-12-01 1:04 ` Arnout Vandecappelle
2013-11-22 22:50 ` [Buildroot] [PATCH 4/5] fs/custom: generate complete, partition-based device images Yann E. MORIN
2013-11-22 22:58 ` Yann E. MORIN
2013-11-25 9:31 ` Arnout Vandecappelle
2013-11-25 19:05 ` Yann E. MORIN
2013-11-25 22:27 ` Arnout Vandecappelle
2013-11-25 22:45 ` Yann E. MORIN
2013-11-25 22:56 ` Arnout Vandecappelle
2013-11-25 23:03 ` Yann E. MORIN
2013-11-26 8:12 ` Arnout Vandecappelle [this message]
2013-11-26 17:06 ` Yann E. MORIN
2013-11-22 22:50 ` [Buildroot] [PATCH 5/5] board/raspberrypi: provide partition description for the new genimanges Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529457D6.8060700@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.