From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Shawn Guo <shawn.guo@linaro.org>,
kernel@pengutronix.de, lst@pengutronix.de,
linux-arm-kernel@lists.infradead.org, linux-can@vger.kernel.org
Subject: Re: [PATCH v2 1/2] can: flexcan: use correct clock as base for bit rate calculation
Date: Tue, 26 Nov 2013 09:35:01 +0100 [thread overview]
Message-ID: <52945D35.70103@pengutronix.de> (raw)
In-Reply-To: <52945B5A.9070601@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 918 bytes --]
On 11/26/2013 09:27 AM, Marc Kleine-Budde wrote:
> On 11/25/2013 10:15 PM, Marc Kleine-Budde wrote:
>> The flexcan IP core uses the peripheral clock ("per") as basic clock for the
>> bit timing calculation. However the driver uses the the wrong clock ("ipg").
>> This leads to wrong bit rates if the rates on both clock are different.
>>
>> This patch fixes the problem by using the correct clock for the bit rate
>> calculation.
>>
>> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
If you take the patch, please add:
Cc: linux-stable <stable@vger.kernel.org>
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: mkl@pengutronix.de (Marc Kleine-Budde)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] can: flexcan: use correct clock as base for bit rate calculation
Date: Tue, 26 Nov 2013 09:35:01 +0100 [thread overview]
Message-ID: <52945D35.70103@pengutronix.de> (raw)
In-Reply-To: <52945B5A.9070601@pengutronix.de>
On 11/26/2013 09:27 AM, Marc Kleine-Budde wrote:
> On 11/25/2013 10:15 PM, Marc Kleine-Budde wrote:
>> The flexcan IP core uses the peripheral clock ("per") as basic clock for the
>> bit timing calculation. However the driver uses the the wrong clock ("ipg").
>> This leads to wrong bit rates if the rates on both clock are different.
>>
>> This patch fixes the problem by using the correct clock for the bit rate
>> calculation.
>>
>> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
If you take the patch, please add:
Cc: linux-stable <stable@vger.kernel.org>
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 259 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131126/5b10d1fc/attachment.sig>
next prev parent reply other threads:[~2013-11-26 8:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 21:15 [PATCH v2 1/2] can + ARM i.MX53: use 24 MHz clock parent on i.MX53 Marc Kleine-Budde
2013-11-25 21:15 ` Marc Kleine-Budde
2013-11-25 21:15 ` [PATCH v2 1/2] can: flexcan: use correct clock as base for bit rate calculation Marc Kleine-Budde
2013-11-25 21:15 ` Marc Kleine-Budde
2013-11-26 8:27 ` Marc Kleine-Budde
2013-11-26 8:27 ` Marc Kleine-Budde
2013-11-26 8:35 ` Marc Kleine-Budde [this message]
2013-11-26 8:35 ` Marc Kleine-Budde
2013-11-25 21:15 ` [PATCH v2 2/2] ARM i.MX5: set CAN peripheral clock to 24 MHz parent Marc Kleine-Budde
2013-11-25 21:15 ` Marc Kleine-Budde
2013-11-26 4:53 ` [PATCH v2 1/2] can + ARM i.MX53: use 24 MHz clock parent on i.MX53 Shawn Guo
2013-11-26 4:53 ` Shawn Guo
2013-11-26 8:26 ` Marc Kleine-Budde
2013-11-26 8:26 ` Marc Kleine-Budde
2013-11-26 14:33 ` Shawn Guo
2013-11-26 14:33 ` Shawn Guo
2013-11-26 14:35 ` Marc Kleine-Budde
2013-11-26 14:35 ` Marc Kleine-Budde
2013-12-03 10:54 ` Marc Kleine-Budde
2013-12-03 10:54 ` Marc Kleine-Budde
2013-12-03 11:46 ` Shawn Guo
2013-12-03 11:46 ` Shawn Guo
2013-12-09 5:59 ` Shawn Guo
2013-12-09 5:59 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52945D35.70103@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=lst@pengutronix.de \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.