From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53858) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VlFJO-0000Yv-Mt for qemu-devel@nongnu.org; Tue, 26 Nov 2013 04:52:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VlFJJ-00018B-QB for qemu-devel@nongnu.org; Tue, 26 Nov 2013 04:52:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52276) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VlFJJ-000187-Gj for qemu-devel@nongnu.org; Tue, 26 Nov 2013 04:52:01 -0500 Message-ID: <52946F3A.8030606@redhat.com> Date: Tue, 26 Nov 2013 10:51:54 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1385456183-24840-1-git-send-email-pl@kamp.de> <1385456183-24840-10-git-send-email-pl@kamp.de> In-Reply-To: <1385456183-24840-10-git-send-email-pl@kamp.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv2 1.8 9/9] qemu-img: increase min_sparse to 128 sectors (64kb) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com Il 26/11/2013 09:56, Peter Lieven ha scritto: > Suggested-by: Paolo Bonzini > Signed-off-by: Peter Lieven > --- > qemu-img.c | 4 ++-- > qemu-img.texi | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/qemu-img.c b/qemu-img.c > index cc7540f..6f1179b 100644 > --- a/qemu-img.c > +++ b/qemu-img.c > @@ -101,7 +101,7 @@ static void help(void) > " '-p' show progress of command (only certain commands)\n" > " '-pp' show progress of command in sectors (only convert command)\n" > " '-q' use Quiet mode - do not print any output (except errors)\n" > - " '-S' indicates the consecutive number of bytes (defaults to 4k) that must\n" > + " '-S' indicates the consecutive number of bytes (defaults to 64k) that must\n" > " contain only zeros for qemu-img to create a sparse image during\n" > " conversion. If the number of bytes is 0, the source will not be scanned for\n" > " unallocated or zero sectors, and the destination image will always be\n" > @@ -1158,7 +1158,7 @@ static int img_convert(int argc, char **argv) > QEMUOptionParameter *out_baseimg_param; > char *options = NULL; > const char *snapshot_name = NULL; > - int min_sparse = 8; /* Need at least 4k of zeros for sparse detection */ > + int min_sparse = 128; /* Need at least 64k of zeros for sparse detection */ > bool quiet = false; > Error *local_err = NULL; > > diff --git a/qemu-img.texi b/qemu-img.texi > index cb4a3eb..c0e86ab 100644 > --- a/qemu-img.texi > +++ b/qemu-img.texi > @@ -195,7 +195,7 @@ Image conversion is also useful to get smaller image when using a > growable format such as @code{qcow} or @code{cow}: the empty sectors > are detected and suppressed from the destination image. > > -@var{sparse_size} indicates the consecutive number of bytes (defaults to 4k) > +@var{sparse_size} indicates the consecutive number of bytes (defaults to 64k) > that must contain only zeros for qemu-img to create a sparse image during > conversion. If @var{sparse_size} is 0, the source will not be scanned for > unallocated or zero sectors, and the destination image will always be > Reviewed-by: Paolo Bonzini