From: Dongmao Zhang <dmzhang@suse.com>
To: dm-devel@redhat.com
Subject: Re: [PATCH 1/1] improve the performance of dm-log-userspace
Date: Tue, 26 Nov 2013 18:12:01 +0800 [thread overview]
Message-ID: <529473F1.6000203@suse.com> (raw)
In-Reply-To: <528DDFD7.6040005@gmail.com>
于 2013年11月21日 18:26, Akira Hayakawa 写道:
> Hi, Dongmao
>
> I think you are using workqueue the wrong way in two places.
>
> 1)
> WQ_NON_REENTRANT is deprecated. You should remove it.
>> + if (lc->integrated_flush) {
>> + lc->dmlog_wq = alloc_workqueue("dmlogd", WQ_NON_REENTRANT | WQ_MEM_RECLAIM, 0);
>
> 2)
> destory_workqueue first calls drain_workqueue which
> then calls flush_workqueue. You should remove the first line of these.
>> + flush_workqueue(lc->dmlog_wq);
>> + destroy_workqueue(lc->dmlog_wq);
>
> Akira
OK, thank you very much
>
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel
>
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2013-11-26 10:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 8:19 [PATCH 1/1] improve the performance of dm-log-userspace dongmao zhang
2013-11-21 10:26 ` Akira Hayakawa
2013-11-26 10:12 ` Dongmao Zhang [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-12-04 5:35 dongmao zhang
2013-12-11 1:17 ` Brassow Jonathan
2013-12-11 8:01 ` Dongmao Zhang
2014-01-06 5:06 ` Dongmao Zhang
2014-01-13 1:18 ` Brassow Jonathan
[not found] <yes>
2013-09-10 9:25 ` [PATCH 0/1] ideas to improve the write performance of cluster dm-raid1 dongmao zhang
2013-09-10 9:25 ` [PATCH 1/1] improve the performance of dm-log-userspace dongmao zhang
2013-10-28 10:07 ` [PATCH 0/1] patches to improve cluster raid1 performance [V3] dongmao zhang
2013-10-28 10:07 ` [PATCH 1/1] improve the performance of dm-log-userspace dongmao zhang
2013-10-30 1:35 ` Brassow Jonathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529473F1.6000203@suse.com \
--to=dmzhang@suse.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.