Re: [PATCH 1/5] usb: musb: conditionally save and restore the context on suspend

[Daniel Mack <zonque@gmail.com>]

On 11/26/2013 11:50 AM, Sergei Shtylyov wrote:
> On 25-11-2013 23:39, Daniel Mack wrote:
> 
>> It appears not all platforms featuring a musb core need to save the musb
>> core registers at suspend time and restore them on resume.
> 
>> The dsps platform does, however. So add a bit in struct
>> musb_hdrc_platform_data to let platforms specify their need of such
>> action being taken.
> 
>> Signed-off-by: Daniel Mack <zonque@gmail.com>
> [...]
> 
>> diff --git a/include/linux/usb/musb.h b/include/linux/usb/musb.h
>> index eb50525..e5a581c 100644
>> --- a/include/linux/usb/musb.h
>> +++ b/include/linux/usb/musb.h
>> @@ -99,6 +99,9 @@ struct musb_hdrc_platform_data {
>>   	/* MUSB_HOST, MUSB_PERIPHERAL, or MUSB_OTG */
>>   	u8		mode;
>>
>> +	/* should the musb core restore registers after suspend? */
>> +	u8		restore_after_suspend:1;
>> +
> 
>     Better placement seems to be with 'extvbus' field which is also 1-bit -- 
> that would save space in the structure.

That patch is deprecated, as things are now done unconditionally,
without consulting this flag.


Daniel