From: Daniel Mack <zonque@gmail.com>
To: balbi@ti.com
Cc: bigeasy@linutronix.de, linux-usb@vger.kernel.org,
linux-omap@vger.kernel.org, neumann@teufel.de
Subject: Re: [PATCH v2 4/4] usb: musb: dsps: add support for suspend and resume
Date: Tue, 26 Nov 2013 13:30:24 +0100 [thread overview]
Message-ID: <52949460.6090708@gmail.com> (raw)
In-Reply-To: <20131125213236.GW18046@saruman.home>
On 11/25/2013 10:32 PM, Felipe Balbi wrote:
> On Mon, Nov 25, 2013 at 10:30:37PM +0100, Daniel Mack wrote:
>> On 11/25/2013 10:29 PM, Felipe Balbi wrote:
>>> Hi,
>>>
>>> On Mon, Nov 25, 2013 at 10:26:43PM +0100, Daniel Mack wrote:
>>>> +static int dsps_resume(struct device *dev)
>>>> +{
>>>> + struct dsps_glue *glue = dev_get_drvdata(dev);
>>>> + const struct dsps_musb_wrapper *wrp = glue->wrp;
>>>> + struct musb *musb = platform_get_drvdata(glue->musb);
>>>> + void __iomem *mbase = musb->ctrl_base;
>>>> +
>>>> + dsps_writel(mbase, wrp->control, glue->context.control);
>>>> + dsps_writel(mbase, wrp->epintr_set, glue->context.epintr);
>>>> + dsps_writel(mbase, wrp->coreintr_set, glue->context.coreintr);
>>>> + dsps_writel(mbase, wrp->phy_utmi, glue->context.phy_utmi);
>>>> + dsps_writel(mbase, wrp->mode, glue->context.mode);
>>>> + dsps_writel(mbase, wrp->tx_mode, glue->context.tx_mode);
>>>> + dsps_writel(mbase, wrp->rx_mode, glue->context.rx_mode);
>>>> +
>>>> + //musb_port_reset(musb, false);
>>>
>>> ????
>>>
>>
>> Urgs. Development left-over. Sorry. You want me to resend the whole
>> series or just this last patch?
>
> just the last patch is fine :-)
Sorry, there was one more hunk that shouldn't be there. I'll resend a v4
with all the patches included again, for reference.
next prev parent reply other threads:[~2013-11-26 12:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 21:26 [PATCH v2 0/4] musb/dsps: suspend related patches for 3.14 (rebased) Daniel Mack
2013-11-25 21:26 ` [PATCH v2 1/4] usb: musb: unconditionally save and restore the context on suspend Daniel Mack
2013-11-25 21:26 ` [PATCH v2 2/4] usb: musb: call musb_port_suspend from musb_bus_suspend Daniel Mack
[not found] ` <1385414803-13212-1-git-send-email-zonque-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-11-25 21:26 ` [PATCH v2 3/4] usb: musb: dsps: add {tx,rx}_mode to wrapper Daniel Mack
2013-11-25 21:26 ` [PATCH v2 4/4] usb: musb: dsps: add support for suspend and resume Daniel Mack
2013-11-25 21:29 ` Felipe Balbi
2013-11-25 21:30 ` Daniel Mack
2013-11-25 21:32 ` Felipe Balbi
2013-11-26 12:30 ` Daniel Mack [this message]
[not found] ` <52949460.6090708-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-11-26 15:57 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52949460.6090708@gmail.com \
--to=zonque@gmail.com \
--cc=balbi@ti.com \
--cc=bigeasy@linutronix.de \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=neumann@teufel.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.