From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44898) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VlHwQ-0006yf-8T for qemu-devel@nongnu.org; Tue, 26 Nov 2013 07:40:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VlHwJ-0006oL-UT for qemu-devel@nongnu.org; Tue, 26 Nov 2013 07:40:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33346) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VlHwJ-0006oB-MI for qemu-devel@nongnu.org; Tue, 26 Nov 2013 07:40:27 -0500 Message-ID: <529496A4.40109@redhat.com> Date: Tue, 26 Nov 2013 13:40:04 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1385456183-24840-1-git-send-email-pl@kamp.de> <1385456183-24840-9-git-send-email-pl@kamp.de> <52947226.1060900@redhat.com> <529492D5.8020406@kamp.de> In-Reply-To: <529492D5.8020406@kamp.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv2 1.8 8/9] qemu-img: add option to show progress in sectors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com Il 26/11/2013 13:23, Peter Lieven ha scritto: >> I think the right way to do this would be to add the functionality to >> qemu-progress.c (i.e. pass a number of sectors and let it choose between >> printing % or sectors). > I was thinking about the same, but is this not beyond the scope of this > patch? ;-) I think the functionality is not important enough to warrant more code in qemu-img.c (even 20 lines is already too much). We should improve the utility libraries instead. > I don't mind leaving this patch out if you or the maintainers are > strongly against it. Yes, please leave it out. Paolo