From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vladimir Davydov Subject: Re: [Devel] [PATCH v11 00/15] kmemcg shrinkers Date: Tue, 26 Nov 2013 16:55:43 +0400 Message-ID: <52949A4F.7030004@parallels.com> References: <20131125174135.GE22729@cmpxchg.org> <529443E4.7080602@parallels.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <529443E4.7080602-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Johannes Weiner Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, glommer-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org, mhocko-AlSwsSmVLrQ@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, devel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org On 11/26/2013 10:47 AM, Vladimir Davydov wrote: > Hi, > > Thank you for the review. I agree with all your comments and I'll > resend the fixed version soon. > > If anyone still has something to say about the patchset, I'd be glad > to hear from them. > > On 11/25/2013 09:41 PM, Johannes Weiner wrote: >> I ran out of steam reviewing these because there were too many things >> that should be changed in the first couple patches. >> >> I realize this is frustrating to see these type of complaints in v11 >> of a patch series, but the review bandwidth was simply exceeded back >> when Glauber submitted this along with the kmem accounting patches. A >> lot of the kmemcg commits themselves don't even have review tags or >> acks, but it all got merged anyway, and the author has moved on to >> different projects... >> >> Too much stuff slips past the only two people that have more than one >> usecase on their agenda and are willing to maintain this code base - >> which is in desparate need of rework and pushback against even more >> drive-by feature dumps. I have repeatedly asked to split the memcg >> tree out of the memory tree to better deal with the vastly different >> developmental stages of memcg and the rest of the mm code, to no >> avail. So I don't know what to do anymore, but this is not working. >> >> Thoughts? > > That's a pity, because w/o this patchset kmemcg is in fact useless. > Perhaps, it's worth trying to split it? (not sure if it'll help much > though since first 11 patches are rather essential :-( ) What do you think about splitting this set into two main series as follows: 1) Prepare vmscan to kmemcg-aware shrinkers; would include patches 1-7 of this set. 2) Make fs shrinkers memcg-aware; would include patches 9-11 of this set and leave other patches, which are rather for optimization/extending functionality, for future? Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lb0-f180.google.com (mail-lb0-f180.google.com [209.85.217.180]) by kanga.kvack.org (Postfix) with ESMTP id 9608D6B0071 for ; Tue, 26 Nov 2013 07:55:53 -0500 (EST) Received: by mail-lb0-f180.google.com with SMTP id w6so4304424lbh.39 for ; Tue, 26 Nov 2013 04:55:52 -0800 (PST) Received: from relay.parallels.com (relay.parallels.com. [195.214.232.42]) by mx.google.com with ESMTPS id k8si4496407lag.19.2013.11.26.04.55.51 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 26 Nov 2013 04:55:51 -0800 (PST) Message-ID: <52949A4F.7030004@parallels.com> Date: Tue, 26 Nov 2013 16:55:43 +0400 From: Vladimir Davydov MIME-Version: 1.0 Subject: Re: [Devel] [PATCH v11 00/15] kmemcg shrinkers References: <20131125174135.GE22729@cmpxchg.org> <529443E4.7080602@parallels.com> In-Reply-To: <529443E4.7080602@parallels.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Johannes Weiner Cc: linux-kernel@vger.kernel.org, glommer@openvz.org, mhocko@suse.cz, linux-mm@kvack.org, cgroups@vger.kernel.org, akpm@linux-foundation.org, devel@openvz.org On 11/26/2013 10:47 AM, Vladimir Davydov wrote: > Hi, > > Thank you for the review. I agree with all your comments and I'll > resend the fixed version soon. > > If anyone still has something to say about the patchset, I'd be glad > to hear from them. > > On 11/25/2013 09:41 PM, Johannes Weiner wrote: >> I ran out of steam reviewing these because there were too many things >> that should be changed in the first couple patches. >> >> I realize this is frustrating to see these type of complaints in v11 >> of a patch series, but the review bandwidth was simply exceeded back >> when Glauber submitted this along with the kmem accounting patches. A >> lot of the kmemcg commits themselves don't even have review tags or >> acks, but it all got merged anyway, and the author has moved on to >> different projects... >> >> Too much stuff slips past the only two people that have more than one >> usecase on their agenda and are willing to maintain this code base - >> which is in desparate need of rework and pushback against even more >> drive-by feature dumps. I have repeatedly asked to split the memcg >> tree out of the memory tree to better deal with the vastly different >> developmental stages of memcg and the rest of the mm code, to no >> avail. So I don't know what to do anymore, but this is not working. >> >> Thoughts? > > That's a pity, because w/o this patchset kmemcg is in fact useless. > Perhaps, it's worth trying to split it? (not sure if it'll help much > though since first 11 patches are rather essential :-( ) What do you think about splitting this set into two main series as follows: 1) Prepare vmscan to kmemcg-aware shrinkers; would include patches 1-7 of this set. 2) Make fs shrinkers memcg-aware; would include patches 9-11 of this set and leave other patches, which are rather for optimization/extending functionality, for future? Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753031Ab3KZMzz (ORCPT ); Tue, 26 Nov 2013 07:55:55 -0500 Received: from relay.parallels.com ([195.214.232.42]:35372 "EHLO relay.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750950Ab3KZMzw (ORCPT ); Tue, 26 Nov 2013 07:55:52 -0500 Message-ID: <52949A4F.7030004@parallels.com> Date: Tue, 26 Nov 2013 16:55:43 +0400 From: Vladimir Davydov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130922 Icedove/17.0.9 MIME-Version: 1.0 To: Johannes Weiner CC: , , , , , , Subject: Re: [Devel] [PATCH v11 00/15] kmemcg shrinkers References: <20131125174135.GE22729@cmpxchg.org> <529443E4.7080602@parallels.com> In-Reply-To: <529443E4.7080602@parallels.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.30.24.145] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/26/2013 10:47 AM, Vladimir Davydov wrote: > Hi, > > Thank you for the review. I agree with all your comments and I'll > resend the fixed version soon. > > If anyone still has something to say about the patchset, I'd be glad > to hear from them. > > On 11/25/2013 09:41 PM, Johannes Weiner wrote: >> I ran out of steam reviewing these because there were too many things >> that should be changed in the first couple patches. >> >> I realize this is frustrating to see these type of complaints in v11 >> of a patch series, but the review bandwidth was simply exceeded back >> when Glauber submitted this along with the kmem accounting patches. A >> lot of the kmemcg commits themselves don't even have review tags or >> acks, but it all got merged anyway, and the author has moved on to >> different projects... >> >> Too much stuff slips past the only two people that have more than one >> usecase on their agenda and are willing to maintain this code base - >> which is in desparate need of rework and pushback against even more >> drive-by feature dumps. I have repeatedly asked to split the memcg >> tree out of the memory tree to better deal with the vastly different >> developmental stages of memcg and the rest of the mm code, to no >> avail. So I don't know what to do anymore, but this is not working. >> >> Thoughts? > > That's a pity, because w/o this patchset kmemcg is in fact useless. > Perhaps, it's worth trying to split it? (not sure if it'll help much > though since first 11 patches are rather essential :-( ) What do you think about splitting this set into two main series as follows: 1) Prepare vmscan to kmemcg-aware shrinkers; would include patches 1-7 of this set. 2) Make fs shrinkers memcg-aware; would include patches 9-11 of this set and leave other patches, which are rather for optimization/extending functionality, for future? Thanks.