From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45007) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VlJss-0002U1-Nn for qemu-devel@nongnu.org; Tue, 26 Nov 2013 09:45:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VlJsn-0004BJ-QZ for qemu-devel@nongnu.org; Tue, 26 Nov 2013 09:45:02 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40817) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VlJsn-0004BF-IQ for qemu-devel@nongnu.org; Tue, 26 Nov 2013 09:44:57 -0500 Message-ID: <5294B3E3.6060906@redhat.com> Date: Tue, 26 Nov 2013 15:44:51 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1385473433-15844-1-git-send-email-akong@redhat.com> <5294A902.5060000@redhat.com> <5294B105.2080000@redhat.com> In-Reply-To: <5294B105.2080000@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] virtio-rng: correct the default limit rate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: amit.shah@redhat.com, "libvir-list@redhat.com" , Amos Kong , qemu-devel@nongnu.org, anthony@codemonkey.ws -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Il 26/11/2013 15:32, Eric Blake ha scritto: > Hmm. Libvirt is already converting a user's rate of bytes/period > into the qemu parameters, defaulting to 1 second as its default > period. Am I correct that as long as libvirt specified both rate > AND period, then this change has no impact (and that the 7% change > occurs if you specify period while leaving max-bytes alone)? Or is > this an ABI change where libvirt will have to be taught to be smart > enough to know whether it is old qemu or new qemu to adjust how > libvirt does its calculations when converting the user's rate into > qemu terms? Yes, it is the former---i.e. you're right. Paolo -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSlLPjAAoJEBvWZb6bTYbyDg8QAIk8BIh5ZY0w4aF7AHufxpmn XtvbGIAdb+ztNBtPrL5HJXAvaOvbZNfktmKDA7Cee1Cq8opJPUZQDpwmv7xUshpG yc1YQu3Djb0/kCDV0oNiMQARSwxJ3XMR94SSLfmlI3b7lJVDeviouhV4UdjS3eal ZNWUXya+1bloOC+zX4P0atB5hyrpVhcVHddWLsIs4+6EYcOatHPgl5CK5f5uxq+P 5qkAe1FJTHMkBOJ86kis3s57ZTTqIlkvFiqtJY4IViifHjbMR4PJraO6EQigOxf6 VdV+MIkPm3GA6F3SYOoZNacITBsaRXTJ0kjD+BjUUAFONB7X8//Uob5gSUgmkED7 ATqiDnqSq1jwyV4FAVwYDB397ViLAZYd9k/ai4QZLaclyMqHQKx+RCNN7dmFwCuL EYK0Z9AkoVkJJQQUcERO3ps/T89+tlBVQhBKpae1V2ZKJqCGxLaf0344S+kFicYk bqp87ra5L5J8Qdn+/eBMJsQNa5NDWjKU0TvZSr3tGGoGKKamzwFmnsTzcZ9DHoTZ IVcdHAbToCYnqbnJzORoxFVycSrY8B2AhZOqIz5YQgNV1LDPcK7hzcXZ+rpBu5mU zF9MFHBKrGJo7l4GyC4jFa5osDfGOyGzMyoSvlMuFTG8CUXN/QLmcpzE+NL1QlCj lL7TLkbhYKrQxUPw37+P =mb5e -----END PGP SIGNATURE-----