From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55366) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VlKcx-0003dO-8g for qemu-devel@nongnu.org; Tue, 26 Nov 2013 10:32:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VlKcs-00021N-Aw for qemu-devel@nongnu.org; Tue, 26 Nov 2013 10:32:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:65270) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VlKcs-000213-2k for qemu-devel@nongnu.org; Tue, 26 Nov 2013 10:32:34 -0500 Message-ID: <5294BF0E.1040603@redhat.com> Date: Tue, 26 Nov 2013 08:32:30 -0700 From: Eric Blake MIME-Version: 1.0 References: <1385473433-15844-1-git-send-email-akong@redhat.com> <5294A902.5060000@redhat.com> <5294B105.2080000@redhat.com> <20131126152352.GC29669@amosk.info> In-Reply-To: <20131126152352.GC29669@amosk.info> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FEdI0fXUjFDMpI7tfxGVb6rgNHdroC3a4" Subject: Re: [Qemu-devel] [PATCH] virtio-rng: correct the default limit rate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong Cc: amit.shah@redhat.com, Paolo Bonzini , anthony@codemonkey.ws, qemu-devel@nongnu.org, "libvir-list@redhat.com" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --FEdI0fXUjFDMpI7tfxGVb6rgNHdroC3a4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/26/2013 08:23 AM, Amos Kong wrote: >> >> Hmm. Libvirt is already converting a user's rate of bytes/period into= >> the qemu parameters, defaulting to 1 second as its default period. >=20 > So libvirt will always pass a fixed 1 second period to qemu? You forced me to check the code :) We're safe. Libvirt lets the user control both rate and period in the XML. If the user specifies neither, then libvirt doesn't pass max-bytes or period (but that's the default for unlimited, and you argued that even with your changes, the default is still effectively unlimited); the same is true if the user specifies period but not rate (a different period with no maximum is still effectively unlimited throughput, so it didn't really matter that we don't pass period on through). It is only when the user specifies rate that libvirt passes anything on to qemu; and in that case, libvirt always passes both max-bytes and period (either with a period set by user, or with the period forced to 1000). >=20 > Nothing need to do in Libvirt for _this patch_ Agreed. Phew. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --FEdI0fXUjFDMpI7tfxGVb6rgNHdroC3a4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSlL8OAAoJEKeha0olJ0NqBPUH/2yz9uCUNdJZq6kPUhsTGhaM OrDoKHJPw2EI1y3tzcdGZF/S1y1f6PBQLmByNSo37lWY5d6HYbv25+paPY2ZsX0L N7fwNJp2WDYNUOk3qhBDpP5o5AvhWMg2epYtqYSfqEniVC8VzCnPdUrzLC/3nbr3 rAo9LkraBUbqU5KzEweSSlhSukhORI02MjH3uuQ7pJYyPJgIB41j1sEuiXuB12sW wybEd9p0vXUDBVfu2T4Xyx14wkMNuQZL6Y48FRkDnuww0OHJWhLZrFsEJ2luz3IS sL/4aoX5RfIs9raiB5twhp9WpoCDQ5Wi8o5wtEf8YqUL6VCB7DMo0QPVyskTQL0= =qUfV -----END PGP SIGNATURE----- --FEdI0fXUjFDMpI7tfxGVb6rgNHdroC3a4--