From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v5 11/12] libxl: ocaml: remove dead code in xentoollog bindings Date: Tue, 26 Nov 2013 18:02:19 +0000 Message-ID: <5294E22B.2060703@citrix.com> References: <1385488371-28875-1-git-send-email-rob.hoes@citrix.com> <1385488371-28875-12-git-send-email-rob.hoes@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1385488371-28875-12-git-send-email-rob.hoes@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Rob Hoes Cc: ian.jackson@citrix.com, dave.scott@eu.citrix.com, ian.campbell@citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 26/11/13 17:52, Rob Hoes wrote: > Found by Coverty. CIDs: 1128567 1128568 1128576 1128577. > > Signed-off-by: Rob Hoes Reviewed-by: Andrew Cooper > --- > tools/ocaml/libs/xentoollog/xentoollog_stubs.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/tools/ocaml/libs/xentoollog/xentoollog_stubs.c b/tools/ocaml/libs/xentoollog/xentoollog_stubs.c > index 87ea53e..46f7f87 100644 > --- a/tools/ocaml/libs/xentoollog/xentoollog_stubs.c > +++ b/tools/ocaml/libs/xentoollog/xentoollog_stubs.c > @@ -92,8 +92,6 @@ static void stub_xtl_ocaml_vmessage(struct xentoollog_logger *logger, > value *func = caml_named_value(xtl->vmessage_cb) ; > char *msg; > > - if (args == NULL) > - caml_raise_out_of_memory(); > if (func == NULL) > caml_raise_sys_error(caml_copy_string("Unable to find callback")); > if (vasprintf(&msg, format, al) < 0) > @@ -123,8 +121,6 @@ static void stub_xtl_ocaml_progress(struct xentoollog_logger *logger, > struct caml_xtl *xtl = (struct caml_xtl*)logger; > value *func = caml_named_value(xtl->progress_cb) ; > > - if (args == NULL) > - caml_raise_out_of_memory(); > if (func == NULL) > caml_raise_sys_error(caml_copy_string("Unable to find callback")); >