Re: [PATCH] - add "fixpae" bootparam to fix/workaround #930447

["H. Peter Anvin" <hpa@zytor.com>]

On 11/26/2013 03:09 PM, Roland Kletzing wrote:
> Hello kernel-team, 
> 
> regarding https://bugs.launchpad.net/ubuntu/+source/syslinux/+bug/930447 , i have developed a simple patch to (hopefully) provide an easy and elegant workaround/fix for the issue. I assume some hundred users (if not some thousand, as entries in bugreports are only the tip of an iceberg) are affected by this issue.
> 
> Please take a review and feel free to merge.
> 
> As defaulting to PAE kernels is specific for some distros only, i think this is no patch for mainline (yet).
> 
> I did not often do patches, nor am i a good programmer - so sorry if the patch or the submission style is not perfect.
> 
> regards
> Roland

No, this is not an acceptable patch per se.

The right way to do this is to have the option, if it is found, simply
set the bit in the CPU array.  However, it is important to verify that
we are on the affected type of CPU, specifically the affected Pentium Ms.

x86 patches should be sent to <x86@kernel.org> or equivalently myself,
<mingo@kernel.org> and <tglx@linutronix.de> and Cc:
<linux-kernel@vger.kernel.org>.  I also encourage you to read the file
Documentation/SubmittingPatches before trying again.

	-hpa