Re: [PATCH] ALSA: hda - Enable mute/mic-mute LEDs for more Thinkpads with Conexant codec

[Hui Wang <hui.wang@canonical.com>]

On 11/27/2013 01:17 PM, David Henningsson wrote:
> On 11/27/2013 04:26 AM, Hui Wang wrote:
>> Most Thinkpad Edge series laptops use conexant codec, so far although
>> the codecs have different minor Vendor Id and minor Subsystem Id, but
>> they all belong to the cxt_5066 family, this change can make the
>> mute/mic-mute LEDs support more generic among cxt_5066 family.
> Hi Hui and thanks for your patch!
>
> It's also nice that you have tested the patch on several machines and
> found it to be working.
>
> As for the actual implementation - as the rest of the thinkpad-acpi code
> is copy-pasted between patch_realtek and patch_conexant, I think this
> would also apply here, i e, no code in hda_local.h, instead copy from
> patch_realtek to patch_conexant as necessary.
>
> While copy-pasting code is not the most elegant of solutions, I got the
> impression from Takashi that he preferred that for now.
OK, got it, I will send a V2 patch according to your suggestion.

Regards,
Hui.
>> Cc: Alex Hung <alex.hung@canonical.com>
>> Cc: David Henningsson <david.henningsson@canonical.com>
>> Signed-off-by: Hui Wang <hui.wang@canonical.com>
>> ---
>>   sound/pci/hda/hda_local.h      | 22 ++++++++++++++++++++++
>>   sound/pci/hda/patch_conexant.c |  3 +++
>>   sound/pci/hda/patch_realtek.c  | 20 --------------------
>>   3 files changed, 25 insertions(+), 20 deletions(-)
>>