From: Dirk Behme <dirk.behme@de.bosch.com>
To: Chris Ball <cjb@laptop.org>
Cc: Shawn Guo <shawn.guo@linaro.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH] mmc: sdhci-esdhc-imx: Write only 4 bit in case of TIMEOUT_CONTROL
Date: Wed, 27 Nov 2013 07:47:39 +0100 [thread overview]
Message-ID: <5295958B.6050509@de.bosch.com> (raw)
In-Reply-To: <87zjoqg8o2.fsf@octavius.laptop.org>
On 26.11.2013 22:22, Chris Ball wrote:
> Hi Dirk,
>
> On Fri, Nov 01 2013, Dirk Behme wrote:
>> On 16.07.2013 09:38, Shawn Guo wrote:
>>> Hi Dirk,
>>>
>>> On Tue, Jul 16, 2013 at 08:36:11AM +0200, Dirk Behme wrote:
>>>> In case of SDHCI_TIMEOUT_CONTROL write only 4 bits and not the
>>>> whole byte to avoid touching other unrelated bits in the i.MX6
>>>> SYS_CTRL register. E.g. IPP_RST_N shouldn't be touched accidently.
>>>>
>>>> Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>
>>>
>>> Acked-by: Shawn Guo <shawn.guo@linaro.org>
>>
>> What's the status of this? I can't find it e.g. in linux-next?
>>
>> Does anybody like to help to apply this?
>
> Looks like you didn't answer Shawn's question yet, could you please?
>
>>> I'm wondering if it fixes any issue in real life?
I wasn't aware that this questions blocks applying that patch. I think
I've answered Shawn's question in a private mail: Using RST_N doesn't
work if the controller's IPP_RST_N bit is touched accidentally, i.e. if
a reset is asserted if it shouldn't.
Many thanks and best regards
Dirk
next prev parent reply other threads:[~2013-11-27 6:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-16 6:36 [PATCH] mmc: sdhci-esdhc-imx: Write only 4 bit in case of TIMEOUT_CONTROL Dirk Behme
2013-07-16 7:38 ` Shawn Guo
2013-11-01 6:31 ` Dirk Behme
2013-11-26 21:22 ` Chris Ball
2013-11-27 6:47 ` Dirk Behme [this message]
2013-11-28 2:21 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5295958B.6050509@de.bosch.com \
--to=dirk.behme@de.bosch.com \
--cc=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.