From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VlZhj-0002k2-CO for kexec@lists.infradead.org; Wed, 27 Nov 2013 07:38:36 +0000 Received: from m4.gw.fujitsu.co.jp (unknown [10.0.50.74]) by fgwmail6.fujitsu.co.jp (Postfix) with ESMTP id C38DB3EE0AE for ; Wed, 27 Nov 2013 16:38:05 +0900 (JST) Received: from smail (m4 [127.0.0.1]) by outgoing.m4.gw.fujitsu.co.jp (Postfix) with ESMTP id B3EAB45DD77 for ; Wed, 27 Nov 2013 16:38:05 +0900 (JST) Received: from s4.gw.fujitsu.co.jp (s4.gw.nic.fujitsu.com [10.0.50.94]) by m4.gw.fujitsu.co.jp (Postfix) with ESMTP id 92E8645DD76 for ; Wed, 27 Nov 2013 16:38:05 +0900 (JST) Received: from s4.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s4.gw.fujitsu.co.jp (Postfix) with ESMTP id 83D1C1DB8032 for ; Wed, 27 Nov 2013 16:38:05 +0900 (JST) Received: from m1000.s.css.fujitsu.com (m1000.s.css.fujitsu.com [10.240.81.136]) by s4.gw.fujitsu.co.jp (Postfix) with ESMTP id 361B11DB8037 for ; Wed, 27 Nov 2013 16:38:05 +0900 (JST) Message-ID: <5295A153.8080400@jp.fujitsu.com> Date: Wed, 27 Nov 2013 16:37:55 +0900 From: HATAYAMA Daisuke MIME-Version: 1.0 Subject: Re: [PATCH v2] makedumpfile: add parameters to update_cyclic_region References: <20131125023150.GB13197@dhcp-16-252.nay.redhat.com> <5292D30E.5070003@jp.fujitsu.com> <20131126025221.GA22934@dhcp-16-252.nay.redhat.com> <0910DD04CBD6DE4193FCF86B9C00BE971C60A8@BPXM01GP.gisp.nec.co.jp> <20131127053731.GA4318@dhcp-16-252.nay.redhat.com> In-Reply-To: <20131127053731.GA4318@dhcp-16-252.nay.redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: Baoquan He Cc: "kexec@lists.infradead.org" , Atsushi Kumagai , "chaowang@redhat.com" (2013/11/27 14:37), Baoquan He wrote: > On 11/26/13 at 03:12am, Atsushi Kumagai wrote: >> Hello Baoquan, >> >> On 2013/11/26 11:53:34, kexec wrote: >>> On 11/25/13 at 01:33pm, HATAYAMA Daisuke wrote: >>>> (2013/11/25 11:31), Baoquan He wrote: >>>>> Hi HATAYAMA and Atsushi, >>>>> >>>>> I think v2 is better than v1, since update_cyclic_region can be used >>>>> with a more flexible calling. >>>>> >>>>> What's your opinion about this? >>>>> >>>>> On 11/23/13 at 05:29pm, Baoquan He wrote: >>>> >>>> Thanks for your patch. The bug is caused by my patch set for creating a >>>> whole part of 1st bitmap before entering cyclic process. >>>> >>>> I think v1 is better than v2. The update_cyclic_range() call relevant >>>> to this regression is somewhat special compared to other calls; it is >>>> the almost only call that doesn't need to perform filtering processing. >>>> To fix this bug, please make the patch so as not to affect the other calls, >>>> in order to keep change as small as possible. >>> >>> OK, if you think so. But I still think update_cyclic_region is a little >>> weird, its name doesn't match its functionality, this confuses code >>> reviewers. And it does something unnecessary somewhere. If it's >>> possible, I would rather take out the create_1st_bitmap_cyclic and >>> exclude_unnecessary_pages_cyclic, and call them explicitly where they >>> are really needed. Surely we can make a little change in both of them, >>> E.g add a parameter pfn to them, then we can also judge like >>> update_cyclic_region has done: >>> >>> if (is_cyclic_region(pfn)) >>> return TRUE; >>> >>> If you insist on v1 is a better idea, I will repost based on it, but keep >>> my personal opinion. >> >> I also prefer v1 because the usage of update_cyclic_region_without_exclude() is >> definite and understandable while v2's update_cyclic_region() is complicated. >> >> On the other hand, I agree with your opinion, so could you post a cleanup patch >> separately from v1 patch ? > > Hi Atsushi, > > Yeah, you are right, v1 is better. Then we can wait for HATAYAMA's cleanup > patch. I know you are goint to release v1.5.5. > I don't have a time to make a clean-up patch now, at least within this year. -- Thanks. HATAYAMA, Daisuke _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec