From mboxrd@z Thu Jan 1 00:00:00 1970 From: nicolas.ferre@atmel.com (Nicolas Ferre) Date: Wed, 27 Nov 2013 09:49:33 +0100 Subject: [PATCH] rtc: at91sam9: include explicitly In-Reply-To: <20131115145554.GC19318@pengutronix.de> References: <1384524058-20712-1-git-send-email-u.kleine-koenig@pengutronix.de> <20131115142327.GQ28304@ns203013.ovh.net> <20131115145554.GC19318@pengutronix.de> Message-ID: <5295B21D.5020308@atmel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 15/11/2013 15:55, Uwe Kleine-K?nig : > Hello, > > On Fri, Nov 15, 2013 at 03:23:27PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: >> On 15:00 Fri 15 Nov , Uwe Kleine-K??nig wrote: >>> The driver needs the symbol AT91_SLOW_CLOCK which is defined in >>> arch/arm/mach-at91/include/mach/hardware.h. This file is included >>> implicitly via linux/module.h -> linux/kmod.h -> linux/gfp.h -> >>> linux/mmzone.h -> linux/memory_hotplug.h -> linux/notifier.h -> >>> linux/srcu.h -> linux/workqueue.h -> linux/timer.h -> linux/ktime.h -> >>> linux/jiffies.h -> linux/timex.h -> mach/timex.h -> mach/hardware.h . >>> >>> So better include it explicitly not only because the last link will go >>> away soon. >>> >>> Signed-off-by: Uwe Kleine-K?nig >> >> we should never use this symbol you need to request the clock clk32k > IMHO this should be addressed in another patch. My intent is to get rid > of . So I let someone else take this patch opportunity. I understand the objective of this patch. So, in the meantime, you have my: Acked-by: Nicolas Ferre (if it is not too late, Uwe). Thanks for addressing that, bye, -- Nicolas Ferre