From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38246)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VldLo-0000UA-DX
	for qemu-devel@nongnu.org; Wed, 27 Nov 2013 06:32:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VldLi-0005na-Te
	for qemu-devel@nongnu.org; Wed, 27 Nov 2013 06:32:12 -0500
Received: from mail-ie0-x230.google.com ([2607:f8b0:4001:c03::230]:58512)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VldLi-0005nV-Od
	for qemu-devel@nongnu.org; Wed, 27 Nov 2013 06:32:06 -0500
Received: by mail-ie0-f176.google.com with SMTP id at1so11793268iec.35
	for <qemu-devel@nongnu.org>; Wed, 27 Nov 2013 03:32:06 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5295D831.1050109@redhat.com>
Date: Wed, 27 Nov 2013 12:32:01 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1385517991-19194-1-git-send-email-famz@redhat.com>
	<1385517991-19194-2-git-send-email-famz@redhat.com>
In-Reply-To: <1385517991-19194-2-git-send-email-famz@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/2] vmdk: Allow read only open of VMDK
	version 3
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

Il 27/11/2013 03:06, Fam Zheng ha scritto:
> +    } else if (le32_to_cpu(header.version) == 3 && flags & BDRV_O_RDWR) {

Parentheses around "flags & BDRV_O_RDWR", please.

I'll try to patch checkpatch.pl to flag this.

Paolo

> +        error_setg(errp, "VMDK version 3 must be read only");
> +        return -EINVAL;
>      }