From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59267)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VletS-0008Pu-VZ
	for qemu-devel@nongnu.org; Wed, 27 Nov 2013 08:11:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VletM-0002DJ-W7
	for qemu-devel@nongnu.org; Wed, 27 Nov 2013 08:11:02 -0500
Received: from cantor2.suse.de ([195.135.220.15]:48362 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VletM-0002DD-QI
	for qemu-devel@nongnu.org; Wed, 27 Nov 2013 08:10:56 -0500
Message-ID: <5295EF5C.7070704@suse.de>
Date: Wed, 27 Nov 2013 14:10:52 +0100
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <cover.1385542228.git.peter.crosthwaite@xilinx.com>	<e14467ff451d76d256e1be017621b68adb758406.1385542228.git.peter.crosthwaite@xilinx.com>	<CAFEAcA-Rqny-KeR9Z6zsMD=vUkyfw+MxwJAea8pbYiCsJ=JtJA@mail.gmail.com>	<5295BE86.9050109@suse.de>	<CAFEAcA-7qpKdnvDwzZH13A2wG1iJqfNK9VdDVF9hS4F9SaAMsA@mail.gmail.com>	<5295C927.6040101@suse.de>
	<CAEgOgz4TMjsWu2MhP382gSxmGErLsCUZecGGnan_WDjWdQmJZw@mail.gmail.com>
In-Reply-To: <CAEgOgz4TMjsWu2MhP382gSxmGErLsCUZecGGnan_WDjWdQmJZw@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH arm-devs v1 2/6] target-arm/cpu: Convert
 reset CBAR to a property
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, QEMU Developers <qemu-devel@nongnu.org>, Mark Langsdorf <mark.langsdorf@calxeda.com>, Igor Mammedov <imammedo@redhat.com>

Hi,

Am 27.11.2013 12:39, schrieb Peter Crosthwaite:
> On Wed, Nov 27, 2013 at 8:27 PM, Andreas F=E4rber <afaerber@suse.de> wr=
ote:
>> Am 27.11.2013 11:15, schrieb Peter Maydell:
>>> On 27 November 2013 09:42, Andreas F=E4rber <afaerber@suse.de> wrote:
>>>> If we turn it into a dynamic property, we could register it conditio=
nal
>>>> to ARM_FEATURE_CBAR.
>>>
>>> Unfortunately feature flags only get set at realize (in the
>>> per-cpu init function), so we don't know at the point where
>>> we're registering properties whether to have this one or not.
>>
>> 1/6 sets it in instance_init actually. So instance_post_init might do.
>>
>=20
> Do you have a candidate example of this pattern that I can work off?

For instance_post_init the only user so far will be in hw/core/qdev.c.

target-i386/cpu.c adds a few dynamic properties for the base X86CPU.

Cheers,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg