All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Ashfield <bruce.ashfield@windriver.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>,
	openembedded-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] module-base: Fix misleading comment
Date: Wed, 27 Nov 2013 08:46:55 -0500	[thread overview]
Message-ID: <5295F7CF.2000506@windriver.com> (raw)
In-Reply-To: <1385559942.11222.1.camel@ted>

On 13-11-27 08:45 AM, Richard Purdie wrote:
> The comment was originally written for module.bbclass and is now
> slightly misleading. This updates it to match the current code.

Acked-by: Bruce Ashfield <bruce.ashfield@windriver.com>

>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
> diff --git a/meta/classes/module-base.bbclass b/meta/classes/module-base.bbclass
> index 9dbb4b4..1589a90 100644
> --- a/meta/classes/module-base.bbclass
> +++ b/meta/classes/module-base.bbclass
> @@ -11,11 +11,8 @@ KERNEL_OBJECT_SUFFIX = ".ko"
>   # kernel modules are generally machine specific
>   PACKAGE_ARCH = "${MACHINE_ARCH}"
>
> -#
> -# Ensure the hostprogs are available for module compilation. Modules that
> -# inherit this recipe and override do_compile() should be sure to call
> -# do_make_scripts() or ensure the scripts are built independently.
> -#
> +# Function to ensure the kernel scripts are created. Expected to
> +# be called before do_compile. See module.bbclass for an exmaple.
>   do_make_scripts() {
>   	unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS
>   	make CC="${KERNEL_CC}" LD="${KERNEL_LD}" AR="${KERNEL_AR}" \
>
>



  reply	other threads:[~2013-11-27 13:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-27 13:45 [PATCH] module-base: Fix misleading comment Richard Purdie
2013-11-27 13:46 ` Bruce Ashfield [this message]
2013-11-27 15:44   ` Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5295F7CF.2000506@windriver.com \
    --to=bruce.ashfield@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.