From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@kernel.org>
Cc: Takashi Iwai <tiwai@suse.de>,
Jean-Francois Moine <moinejf@free.fr>,
alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH 2/2] ASoC: pcm: Always honor DAI min and max sample rate constraints
Date: Wed, 27 Nov 2013 16:01:48 +0100 [thread overview]
Message-ID: <5296095C.2080203@metafoo.de> (raw)
In-Reply-To: <20131127144953.GV14725@sirena.org.uk>
On 11/27/2013 03:49 PM, Mark Brown wrote:
[...]
>> I think Lars' fix will handle such a case nicely now; at least,
>> merging between RATE bits and rate_min/max is solved, as long as the
>> given conditions are consistent.
>
> Yes, it should work for the time being. It just seems silly to have
> more than one set of merging code, it just increases the chances we'll
> get stuff wrong - switching to use the core constraint merging code
> should avoid the possibility of such errors in future.
There isn't such code in the ALSA core yet, but I guess it makes sense to
add it.
- Lars
next prev parent reply other threads:[~2013-11-27 15:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 8:58 [PATCH 1/2] ASoC: soc_pcm_init_runtime_hw: Fix rate_max calculation Lars-Peter Clausen
2013-11-27 8:58 ` [PATCH 2/2] ASoC: pcm: Always honor DAI min and max sample rate constraints Lars-Peter Clausen
2013-11-27 10:31 ` Takashi Iwai
2013-11-27 11:18 ` Lars-Peter Clausen
2013-11-27 11:26 ` Takashi Iwai
2013-11-27 12:21 ` Mark Brown
2013-11-27 13:13 ` Takashi Iwai
2013-11-27 14:49 ` Mark Brown
2013-11-27 15:01 ` Lars-Peter Clausen [this message]
2013-11-27 16:43 ` Mark Brown
2013-11-27 16:42 ` [PATCH 1/2] ASoC: soc_pcm_init_runtime_hw: Fix rate_max calculation Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5296095C.2080203@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=moinejf@free.fr \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.