All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Baron <jbaron@akamai.com>
To: Felipe Contreras <felipe.contreras@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Levente Kurusa <levex@linux.com>
Subject: Re: [PATCH v4 1/2] panic: setup panic_timeout early
Date: Wed, 27 Nov 2013 10:47:01 -0500	[thread overview]
Message-ID: <529613F5.7080503@akamai.com> (raw)
In-Reply-To: <1385533070-7604-2-git-send-email-felipe.contreras@gmail.com>

On 11/27/2013 01:17 AM, Felipe Contreras wrote:
> Otherwise we might not reboot when the user needs it the most (early
> on).
>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
>  kernel/panic.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/panic.c b/kernel/panic.c
> index b6c482c..3456652 100644
> --- a/kernel/panic.c
> +++ b/kernel/panic.c
> @@ -468,9 +468,14 @@ EXPORT_SYMBOL(__stack_chk_fail);
>  
>  #endif
>  
> -core_param(panic, panic_timeout, int, 0644);
>  core_param(pause_on_oops, pause_on_oops, int, 0644);
>  
> +static int __init set_panic_timeout(char *val)
> +{
> +	return kstrtoint(val, 0, &panic_timeout);
> +}
> +early_param("panic_timeout", set_panic_timeout);
> +
>  static int __init oops_setup(char *s)
>  {
>  	if (!s)

hmm....so this changes the comand-line parameter panic=x  to:
panic_timeout=x. The naming might not be the best, but we are
really stuck with it at this point.

Thanks,

-Jason
 

  reply	other threads:[~2013-11-27 15:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-27  6:17 [PATCH v4 0/2] Setup panic params early Felipe Contreras
2013-11-27  6:17 ` [PATCH v4 1/2] panic: setup panic_timeout early Felipe Contreras
2013-11-27 15:47   ` Jason Baron [this message]
2013-11-27 16:43     ` Felipe Contreras
2013-11-27  6:17 ` [PATCH v4 2/2] panic: setup panic_on_oops early Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=529613F5.7080503@akamai.com \
    --to=jbaron@akamai.com \
    --cc=akpm@linux-foundation.org \
    --cc=felipe.contreras@gmail.com \
    --cc=levex@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.