From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41520) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VlhW8-0003on-1J for qemu-devel@nongnu.org; Wed, 27 Nov 2013 10:59:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VlhVx-0004Va-Ia for qemu-devel@nongnu.org; Wed, 27 Nov 2013 10:59:07 -0500 Received: from mail-ie0-x22c.google.com ([2607:f8b0:4001:c03::22c]:58572) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VlhVx-0004VW-DG for qemu-devel@nongnu.org; Wed, 27 Nov 2013 10:58:57 -0500 Received: by mail-ie0-f172.google.com with SMTP id qd12so12480144ieb.3 for ; Wed, 27 Nov 2013 07:58:56 -0800 (PST) Sender: Paolo Bonzini Message-ID: <529616BB.9090901@redhat.com> Date: Wed, 27 Nov 2013 16:58:51 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1385557363-25756-1-git-send-email-vasilis.liaskovitis@profitbricks.com> <20131127165330.075dcf41@nial.usersys.redhat.com> In-Reply-To: <20131127165330.075dcf41@nial.usersys.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v2] i386: Add _PXM ACPI method to CPU objects List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: Vasilis Liaskovitis , thilo.fromm@profitbricks.com, seabios@seabios.org, qemu-devel@nongnu.org, mst@redhat.com Il 27/11/2013 16:53, Igor Mammedov ha scritto: > Patch looks good, > Please add patch to update hw/i386/ssdt-proc.hex.generated for hosts without iasl > for completness Also please rename PXM to CPXM or CPPX for consistency. Paolo >> > >> > --- >> > hw/i386/acpi-build.c | 5 +++++ >> > hw/i386/ssdt-proc.dsl | 5 +++++ >> > 2 files changed, 10 insertions(+) >> > >> > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c >> > index d089e1e..3c11ddc 100644 >> > --- a/hw/i386/acpi-build.c >> > +++ b/hw/i386/acpi-build.c >> > @@ -603,6 +603,7 @@ static inline char acpi_get_hex(uint32_t val) >> > #define ACPI_PROC_OFFSET_CPUHEX (*ssdt_proc_name - *ssdt_proc_start + 2) >> > #define ACPI_PROC_OFFSET_CPUID1 (*ssdt_proc_name - *ssdt_proc_start + 4) >> > #define ACPI_PROC_OFFSET_CPUID2 (*ssdt_proc_id - *ssdt_proc_start) >> > +#define ACPI_PROC_OFFSET_CPUPXM (*ssdt_proc_pxm - *ssdt_proc_start) >> > #define ACPI_PROC_SIZEOF (*ssdt_proc_end - *ssdt_proc_start) >> > #define ACPI_PROC_AML (ssdp_proc_aml + *ssdt_proc_start) >> > >> > @@ -724,6 +725,10 @@ build_ssdt(GArray *table_data, GArray *linker, >> > proc[ACPI_PROC_OFFSET_CPUHEX+1] = acpi_get_hex(i); >> > proc[ACPI_PROC_OFFSET_CPUID1] = i; >> > proc[ACPI_PROC_OFFSET_CPUID2] = i; >> > + proc[ACPI_PROC_OFFSET_CPUPXM] = guest_info->node_cpu[i]; >> > + proc[ACPI_PROC_OFFSET_CPUPXM + 1] = 0; >> > + proc[ACPI_PROC_OFFSET_CPUPXM + 2] = 0; >> > + proc[ACPI_PROC_OFFSET_CPUPXM + 3] = 0; >> > } >> > >> > /* build this code: >> > diff --git a/hw/i386/ssdt-proc.dsl b/hw/i386/ssdt-proc.dsl >> > index 8229bfd..8d4c5bf 100644 >> > --- a/hw/i386/ssdt-proc.dsl >> > +++ b/hw/i386/ssdt-proc.dsl >> > @@ -47,6 +47,8 @@ DefinitionBlock ("ssdt-proc.aml", "SSDT", 0x01, "BXPC", "BXSSDT", 0x1) >> > * also updating the C code. >> > */ >> > Name(_HID, "ACPI0007") >> > + ACPI_EXTRACT_NAME_DWORD_CONST ssdt_proc_pxm >> > + Name(PXM, 0xAAAAAAAA) >> > External(CPMA, MethodObj) >> > External(CPST, MethodObj) >> > External(CPEJ, MethodObj) >> > @@ -59,5 +61,8 @@ DefinitionBlock ("ssdt-proc.aml", "SSDT", 0x01, "BXPC", "BXSSDT", 0x1) >> > Method(_EJ0, 1, NotSerialized) { >> > CPEJ(ID, Arg0) >> > } >> > + Method(_PXM, 0) { >> > + Return (PXM) >> > + } >> > }