From: Sourav Poddar <sourav.poddar@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: devicetree@vger.kernel.org, computersforpeace@gmail.com,
balbi@ti.com, linux-spi@vger.kernel.org,
linux-mtd@lists.infradead.org, bcousson@baylibre.com,
linux-omap@vger.kernel.org
Subject: Re: [PATCH 02/17] spi/spi.h: Add configure from slave support.
Date: Thu, 28 Nov 2013 10:17:38 +0530 [thread overview]
Message-ID: <5296CAEA.3030002@ti.com> (raw)
In-Reply-To: <20131126122159.GB14725@sirena.org.uk>
On Tuesday 26 November 2013 05:51 PM, Mark Brown wrote:
> On Tue, Nov 26, 2013 at 04:51:53PM +0530, Sourav Poddar wrote:
>> On Tuesday 26 November 2013 03:59 PM, Mark Brown wrote:
>>>> + void (*configure_from_slave)(struct spi_device *spi, u8 *val);
>>> Clearly this is far too unstructured to be useful, this is only ever
>>> going to work with one specific combination of slave and master since
>>> there's absolutely no semantics defined.
>> I thought "val" might be good enuf, and this can be filled with whatever
>> data that need to be used from slave into master(irrespective of
>> slave and master?).
> The name isn't the issue, it's the fact that you're passing a completely
> unspecified blob of data.
May be, what you are suggesting here is to we should define a flash
information
structure and should pass that structure here ?
WARNING: multiple messages have this Message-ID (diff)
From: Sourav Poddar <sourav.poddar@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: computersforpeace@gmail.com, linux-mtd@lists.infradead.org,
linux-spi@vger.kernel.org, balbi@ti.com,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
bcousson@baylibre.com
Subject: Re: [PATCH 02/17] spi/spi.h: Add configure from slave support.
Date: Thu, 28 Nov 2013 10:17:38 +0530 [thread overview]
Message-ID: <5296CAEA.3030002@ti.com> (raw)
In-Reply-To: <20131126122159.GB14725@sirena.org.uk>
On Tuesday 26 November 2013 05:51 PM, Mark Brown wrote:
> On Tue, Nov 26, 2013 at 04:51:53PM +0530, Sourav Poddar wrote:
>> On Tuesday 26 November 2013 03:59 PM, Mark Brown wrote:
>>>> + void (*configure_from_slave)(struct spi_device *spi, u8 *val);
>>> Clearly this is far too unstructured to be useful, this is only ever
>>> going to work with one specific combination of slave and master since
>>> there's absolutely no semantics defined.
>> I thought "val" might be good enuf, and this can be filled with whatever
>> data that need to be used from slave into master(irrespective of
>> slave and master?).
> The name isn't the issue, it's the fact that you're passing a completely
> unspecified blob of data.
May be, what you are suggesting here is to we should define a flash
information
structure and should pass that structure here ?
WARNING: multiple messages have this Message-ID (diff)
From: Sourav Poddar <sourav.poddar@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: <computersforpeace@gmail.com>, <linux-mtd@lists.infradead.org>,
<linux-spi@vger.kernel.org>, <balbi@ti.com>,
<linux-omap@vger.kernel.org>, <devicetree@vger.kernel.org>,
<bcousson@baylibre.com>
Subject: Re: [PATCH 02/17] spi/spi.h: Add configure from slave support.
Date: Thu, 28 Nov 2013 10:17:38 +0530 [thread overview]
Message-ID: <5296CAEA.3030002@ti.com> (raw)
In-Reply-To: <20131126122159.GB14725@sirena.org.uk>
On Tuesday 26 November 2013 05:51 PM, Mark Brown wrote:
> On Tue, Nov 26, 2013 at 04:51:53PM +0530, Sourav Poddar wrote:
>> On Tuesday 26 November 2013 03:59 PM, Mark Brown wrote:
>>>> + void (*configure_from_slave)(struct spi_device *spi, u8 *val);
>>> Clearly this is far too unstructured to be useful, this is only ever
>>> going to work with one specific combination of slave and master since
>>> there's absolutely no semantics defined.
>> I thought "val" might be good enuf, and this can be filled with whatever
>> data that need to be used from slave into master(irrespective of
>> slave and master?).
> The name isn't the issue, it's the fact that you're passing a completely
> unspecified blob of data.
May be, what you are suggesting here is to we should define a flash
information
structure and should pass that structure here ?
next prev parent reply other threads:[~2013-11-28 4:48 UTC|newest]
Thread overview: 144+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-26 7:34 [PATCH 00/17] Add memory mapped support for ti qspi, m25p80 serial flash Sourav Poddar
2013-11-26 7:34 ` Sourav Poddar
2013-11-26 7:34 ` Sourav Poddar
2013-11-26 7:34 ` [PATCH 01/17] spi/spi.h: Add get_buf/put_buf support in spi master Sourav Poddar
2013-11-26 7:34 ` Sourav Poddar
2013-11-26 7:34 ` Sourav Poddar
2013-11-26 12:38 ` Mark Brown
2013-11-26 12:38 ` Mark Brown
2013-11-26 7:34 ` [PATCH 02/17] spi/spi.h: Add configure from slave support Sourav Poddar
2013-11-26 7:34 ` Sourav Poddar
2013-11-26 7:34 ` Sourav Poddar
2013-11-26 10:29 ` Mark Brown
2013-11-26 10:29 ` Mark Brown
2013-11-26 11:21 ` Sourav Poddar
2013-11-26 11:21 ` Sourav Poddar
2013-11-26 11:21 ` Sourav Poddar
2013-11-26 12:21 ` Mark Brown
2013-11-26 12:21 ` Mark Brown
2013-11-28 4:47 ` Sourav Poddar [this message]
2013-11-28 4:47 ` Sourav Poddar
2013-11-28 4:47 ` Sourav Poddar
2013-11-28 10:55 ` Mark Brown
2013-11-28 10:55 ` Mark Brown
2013-11-26 7:34 ` [PATCH 03/17] spi/qspi: parse register by name Sourav Poddar
2013-11-26 7:34 ` Sourav Poddar
2013-11-26 7:34 ` Sourav Poddar
2013-11-26 10:30 ` Mark Brown
2013-11-26 10:30 ` Mark Brown
2013-11-26 11:17 ` Sourav Poddar
2013-11-26 11:17 ` Sourav Poddar
2013-11-26 11:17 ` Sourav Poddar
2013-11-26 12:24 ` Mark Brown
2013-11-26 12:24 ` Mark Brown
2013-11-28 4:45 ` Sourav Poddar
2013-11-28 4:45 ` Sourav Poddar
2013-11-28 4:45 ` Sourav Poddar
2013-11-28 10:54 ` Mark Brown
2013-11-28 10:54 ` Mark Brown
2013-11-28 10:58 ` Sourav Poddar
2013-11-28 10:58 ` Sourav Poddar
2013-11-28 10:58 ` Sourav Poddar
2013-11-28 11:11 ` Mark Brown
2013-11-28 11:11 ` Mark Brown
2013-11-28 11:19 ` Sourav Poddar
2013-11-28 11:19 ` Sourav Poddar
2013-11-28 11:19 ` Sourav Poddar
2013-11-26 7:35 ` [PATCH 04/17] spi/qspi: parse control module register Sourav Poddar
2013-11-26 7:35 ` Sourav Poddar
2013-11-26 7:35 ` Sourav Poddar
2013-11-26 10:31 ` Mark Brown
2013-11-26 10:31 ` Mark Brown
2013-11-26 11:18 ` Sourav Poddar
2013-11-26 11:18 ` Sourav Poddar
2013-11-26 11:18 ` Sourav Poddar
2013-11-26 12:25 ` Mark Brown
2013-11-26 12:25 ` Mark Brown
2013-11-26 12:38 ` Sourav Poddar
2013-11-26 12:38 ` Sourav Poddar
2013-11-26 12:38 ` Sourav Poddar
2013-11-26 12:55 ` Mark Brown
2013-11-26 12:55 ` Mark Brown
2013-11-26 13:00 ` Sourav Poddar
2013-11-26 13:00 ` Sourav Poddar
2013-11-26 13:19 ` Mark Brown
2013-11-26 13:19 ` Mark Brown
2013-11-26 13:20 ` Sourav Poddar
2013-11-26 13:20 ` Sourav Poddar
2013-11-26 13:20 ` Sourav Poddar
2013-11-26 7:35 ` [PATCH 05/17] spi/qspi: parse memory map register Sourav Poddar
2013-11-26 7:35 ` Sourav Poddar
2013-11-26 7:35 ` Sourav Poddar
2013-11-26 7:35 ` [PATCH 06/17] spi/qspi: Add support to switc to memory mapped operation Sourav Poddar
2013-11-26 7:35 ` Sourav Poddar
2013-11-26 7:35 ` Sourav Poddar
2013-11-26 12:57 ` Mark Brown
2013-11-26 12:57 ` Mark Brown
2013-11-28 4:39 ` Sourav Poddar
2013-11-28 4:39 ` Sourav Poddar
2013-11-28 4:39 ` Sourav Poddar
2013-11-26 7:35 ` [PATCH 07/17] spi/qspi: configure set up register for memory map Sourav Poddar
2013-11-26 7:35 ` Sourav Poddar
2013-11-26 7:35 ` Sourav Poddar
2013-11-26 7:35 ` [PATCH 08/17] spi/qspi: Add api for get_buf/put_buf Sourav Poddar
2013-11-26 7:35 ` Sourav Poddar
2013-11-26 7:35 ` Sourav Poddar
2013-11-26 7:35 ` [PATCH 09/17] spi/spi.h: Add "mem" variable in spi master Sourav Poddar
2013-11-26 7:35 ` Sourav Poddar
2013-11-26 7:35 ` Sourav Poddar
2013-11-26 13:01 ` Mark Brown
2013-11-26 13:01 ` Mark Brown
2013-11-26 13:05 ` Sourav Poddar
2013-11-26 13:05 ` Sourav Poddar
2013-11-26 13:05 ` Sourav Poddar
2013-11-26 13:20 ` Mark Brown
2013-11-26 13:20 ` Mark Brown
2013-11-28 4:38 ` Sourav Poddar
2013-11-28 4:38 ` Sourav Poddar
2013-11-28 4:38 ` Sourav Poddar
2013-11-26 7:35 ` [PATCH 10/17] spi/spi.h: Add mmap flag " Sourav Poddar
2013-11-26 7:35 ` Sourav Poddar
2013-11-26 7:35 ` Sourav Poddar
2013-11-26 7:35 ` [PATCH 11/17] spi/qspi: set "mmap" flag to true Sourav Poddar
2013-11-26 7:35 ` Sourav Poddar
2013-11-26 7:35 ` Sourav Poddar
2013-11-26 13:10 ` Mark Brown
2013-11-26 13:10 ` Mark Brown
2013-11-26 13:11 ` Sourav Poddar
2013-11-26 13:11 ` Sourav Poddar
2013-11-26 13:11 ` Sourav Poddar
2013-11-26 7:35 ` [PATCH 12/17] spi/qspi: convert driver to enable/disable memory mapped Sourav Poddar
2013-11-26 7:35 ` Sourav Poddar
2013-11-26 7:35 ` Sourav Poddar
2013-11-26 13:11 ` Mark Brown
2013-11-26 13:11 ` Mark Brown
2013-11-28 5:24 ` Sourav Poddar
2013-11-28 5:24 ` Sourav Poddar
2013-11-28 10:49 ` Mark Brown
2013-11-28 10:49 ` Mark Brown
2013-11-28 11:08 ` Sourav Poddar
2013-11-28 11:08 ` Sourav Poddar
2013-11-28 11:08 ` Sourav Poddar
2013-11-28 11:59 ` Mark Brown
2013-11-28 11:59 ` Mark Brown
2013-11-28 12:02 ` Sourav Poddar
2013-11-28 12:02 ` Sourav Poddar
2013-11-28 12:02 ` Sourav Poddar
2013-11-26 7:35 ` [PATCH 13/17] drivers: mtd: m25p80: Add api to configure master register Sourav Poddar
2013-11-26 7:35 ` Sourav Poddar
2013-11-26 7:35 ` Sourav Poddar
2013-11-26 7:35 ` [PATCH 14/17] drivers: mtd: m25p80: Adapt driver to support memory mapped read Sourav Poddar
2013-11-26 7:35 ` Sourav Poddar
2013-11-26 7:35 ` Sourav Poddar
2013-11-26 7:35 ` [PATCH 15/17] arm: dts: dra7: Add qspi device Sourav Poddar
2013-11-26 7:35 ` Sourav Poddar
2013-11-26 7:35 ` Sourav Poddar
2013-11-26 7:35 ` [PATCH 16/17] arm: dts: am43x-epos: " Sourav Poddar
2013-11-26 7:35 ` Sourav Poddar
2013-11-26 7:35 ` Sourav Poddar
2013-11-26 7:35 ` [PATCH 17/17] Documentation: bindings: ti-qspi: update binding information Sourav Poddar
2013-11-26 7:35 ` Sourav Poddar
2013-11-26 7:35 ` Sourav Poddar
2013-12-05 9:09 ` [PATCH 00/17] Add memory mapped support for ti qspi, m25p80 serial flash Sourav Poddar
2013-12-05 9:09 ` Sourav Poddar
2013-12-05 9:09 ` Sourav Poddar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5296CAEA.3030002@ti.com \
--to=sourav.poddar@ti.com \
--cc=balbi@ti.com \
--cc=bcousson@baylibre.com \
--cc=broonie@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.