Re: [RFC nftables kernel PATCH] netfilter: nf_tables: fix nft_meta_target module

[Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>]

Hi Arturo,

Minor stuff:

> + * @NFT_META_TARGET_MARK: to stablish packet mark (skb->mark)

to 'e'stablish

Why not reusing existing NFT_META_* keys?
It would just raise an error if not priority/mark/nftrace/secmark, as it 
does currently.
Worth to keep that as it is imho, no need to duplicate.

Besides that, any other name that would be more relevant than meta_target?
Target is already a critical in-use keyword in netfilter, so it's not 
clear enough.
All expression have a short, one-word based name, which is nice.


Anyway, doesn't it work already: if you create an immediate expression 
(to load the value you want, at default dreg 0 aka NFT_REG_VERDICT) and 
a meta expression without the NFTA_META_DREG set? (didn't try myself)

If not maybe there is a shorter way to fix this, instead of creating a 
full new expression. Looks like it was the original plan.


Tomasz