From mboxrd@z Thu Jan  1 00:00:00 1970
From: Zdenek Kabelac <zkabelac@redhat.com>
Date: Thu, 28 Nov 2013 14:57:59 +0100
Subject: [PATCH] clvmd: closedown the cluster after finishing of lvm_thread
In-Reply-To: <1385542604-11708-1-git-send-email-dmzhang@suse.com>
References: <1385542604-11708-1-git-send-email-dmzhang@suse.com>
Message-ID: <52974BE7.1080206@redhat.com>
List-Id: <lvm-devel.redhat.com>
To: lvm-devel@redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

Dne 27.11.2013 09:56, dongmao zhang napsal(a):
> when lvm_thread is processing remote request, the clvmd
> received a SIG_TERM, it will free cluster resource before
> the realwork of lvm_thread is done. If freeing the cluster
> resource happens before send_message, it would cause the
> remote command hangs forever.
>
> this patch move closedown after the closing the working thread.
> ---
>   daemons/clvmd/clvmd.c |    3 ++-
>   1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/daemons/clvmd/clvmd.c b/daemons/clvmd/clvmd.c
> index d57c0fd..b2f7dd5 100644
> --- a/daemons/clvmd/clvmd.c
> +++ b/daemons/clvmd/clvmd.c
> @@ -621,6 +621,8 @@ int main(int argc, char *argv[])
>   	if ((errno = pthread_join(lvm_thread, NULL)))
>   		log_sys_error("pthread_join", "");
>
> +	clops->cluster_closedown();
> +
>   	close_local_sock(local_sock);
>   	destroy_lvm();
>
> @@ -979,7 +981,6 @@ static void main_loop(int local_sock, int cmd_timeout)
>   	}
>
>         closedown:
> -	clops->cluster_closedown();
>   	if (quit)
>   		DEBUGLOG("SIGTERM received\n");
>   }


It's not clear to me how this  code move helps to anything.

You just moved call of  clops->cluster_closedown(); after joining thread?

In which code path this patch is changing something ?

Zdenek