All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Cc: Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 8/9] savevm: Small comment about why timer QEMUFile/VMState code is in savevm.c
Date: Thu, 28 Nov 2013 15:13:39 +0100	[thread overview]
Message-ID: <52974F93.5060308@suse.de> (raw)
In-Reply-To: <1385647278-30043-9-git-send-email-ehabkost@redhat.com>

Am 28.11.2013 15:01, schrieb Eduardo Habkost:
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  savevm.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/savevm.c b/savevm.c
> index 8eeb5ef..a2c2173 100644
> --- a/savevm.c
> +++ b/savevm.c
> @@ -166,7 +166,9 @@ static QEMUFile *qemu_fopen_bdrv(BlockDriverState *bs, int is_writable)
>  }
>  
>  
> -/* timer */
> +/* QEMUFile timer support.
> + * Not in qemu-file.c to not add qemu-file.c as dependency to qemu-file.c

Typo?

Andreas

> + */
>  
>  void timer_put(QEMUFile *f, QEMUTimer *ts)
>  {
> @@ -189,7 +191,9 @@ void timer_get(QEMUFile *f, QEMUTimer *ts)
>  }
>  
>  
> -/* timers  */
> +/* VMState timer support.
> + * Not in vmstate.c to not add qemu-file.c as dependency to vmstate.c
> + */
>  
>  static int get_timer(QEMUFile *f, void *pv, size_t size)
>  {
> 


-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

  reply	other threads:[~2013-11-28 14:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-28 14:01 [Qemu-devel] [PATCH 0/9] vmstate code split + unit tests Eduardo Habkost
2013-11-28 14:01 ` [Qemu-devel] [PATCH 1/9] qemu-file: Make a few functions non-static Eduardo Habkost
2013-11-28 14:01 ` [Qemu-devel] [PATCH 2/9] migration: Move QEMU_VM_* defines to migration/migration.h Eduardo Habkost
2013-11-28 14:01 ` [Qemu-devel] [PATCH 3/9] savevm: Convert all tabs to spaces Eduardo Habkost
2013-11-28 14:01 ` [Qemu-devel] [PATCH 4/9] savevm.c: Coding style fixes Eduardo Habkost
2013-11-28 14:01 ` [Qemu-devel] [PATCH 5/9] savevm.c: Coding style fix Eduardo Habkost
2013-11-28 14:01 ` [Qemu-devel] [PATCH 6/9] vmstate: Move VMState code to vmstate.c Eduardo Habkost
2013-11-28 14:01 ` [Qemu-devel] [PATCH 7/9] qemu-file: Move QEMUFile code to qemu-file.c Eduardo Habkost
2013-11-28 14:01 ` [Qemu-devel] [PATCH 8/9] savevm: Small comment about why timer QEMUFile/VMState code is in savevm.c Eduardo Habkost
2013-11-28 14:13   ` Andreas Färber [this message]
2013-11-28 14:22     ` Eduardo Habkost
2013-11-29 14:26       ` [Qemu-devel] [PATCH 8/9 v2] " Eduardo Habkost
2013-11-28 14:01 ` [Qemu-devel] [PATCH 9/9] tests: Some unit tests for vmstate.c Eduardo Habkost
2013-12-05 13:16 ` [Qemu-devel] [PATCH 0/9] vmstate code split + unit tests Orit Wasserman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52974F93.5060308@suse.de \
    --to=afaerber@suse.de \
    --cc=ehabkost@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.