From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH 3/4] x86/mem_sharing: drop unused variable. Date: Thu, 28 Nov 2013 16:50:24 +0000 Message-ID: <52977450.8000905@citrix.com> References: <1385656665-12551-1-git-send-email-tim@xen.org> <1385656665-12551-4-git-send-email-tim@xen.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1385656665-12551-4-git-send-email-tim@xen.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tim Deegan Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 28/11/13 16:37, Tim Deegan wrote: > Coverity CID 1087198 > > Signed-off-by: Tim Deegan Reviewed-by: Andrew Cooper > --- > xen/arch/x86/mm/mem_sharing.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/xen/arch/x86/mm/mem_sharing.c b/xen/arch/x86/mm/mem_sharing.c > index 1e89f6c..8355f94 100644 > --- a/xen/arch/x86/mm/mem_sharing.c > +++ b/xen/arch/x86/mm/mem_sharing.c > @@ -833,7 +833,6 @@ int mem_sharing_nominate_page(struct domain *d, > mfn_t mfn; > struct page_info *page = NULL; /* gcc... */ > int ret; > - struct gfn_info *gfn_info; > > *phandle = 0UL; > > @@ -892,7 +891,7 @@ int mem_sharing_nominate_page(struct domain *d, > page->sharing->handle = get_next_handle(); > > /* Create the local gfn info */ > - if ( (gfn_info = mem_sharing_gfn_alloc(page, d, gfn)) == NULL ) > + if ( mem_sharing_gfn_alloc(page, d, gfn) == NULL ) > { > xfree(page->sharing); > page->sharing = NULL;