All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ravi kumar Veeramally <ravikumar.veeramally@linux.intel.com>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH_v2 3/7] profiles/network: Rename common.c|h to bnep.c|h
Date: Thu, 28 Nov 2013 21:52:37 +0200	[thread overview]
Message-ID: <52979F05.3040803@linux.intel.com> (raw)
In-Reply-To: <CABBYNZJVZUjsTpgbAWx7J+gg4OYd4SkzvH+2nLAqaMnH-rm49Q@mail.gmail.com>

Hi Luiz,

On 28.11.2013 18:19, Luiz Augusto von Dentz wrote:
> Hi Ravi,
>
> On Thu, Nov 28, 2013 at 4:45 PM, Ravi kumar Veeramally
> <ravikumar.veeramally@linux.intel.com> wrote:
>> Files common.c|h contains only bnep related code, it makes
>> more sence with bnep.c|h.
>> ---
>>   Makefile.plugins              |   2 +-
>>   profiles/network/bnep.c       | 453 ++++++++++++++++++++++++++++++++++++++++++
>>   profiles/network/bnep.h       |  42 ++++
>>   profiles/network/common.c     | 453 ------------------------------------------
>>   profiles/network/common.h     |  42 ----
>>   profiles/network/connection.c |   2 +-
>>   profiles/network/manager.c    |   2 +-
>>   profiles/network/server.c     |   2 +-
>>   8 files changed, 499 insertions(+), 499 deletions(-)
>>   create mode 100644 profiles/network/bnep.c
>>   create mode 100644 profiles/network/bnep.h
>>   delete mode 100644 profiles/network/common.c
>>   delete mode 100644 profiles/network/common.h
> Did you use git mv? I would expect something like the following if did:
  Yes, I did git mv.
   reason might be bnep.c has it's own include file bnep.h.
   So bnpe.c is 99% bnep.h 100%.

> ---
>   profiles/network/{common.c => bnep.c} | 0
>   profiles/network/{common.h => bnep.h} | 0
>   2 files changed, 0 insertions(+), 0 deletions(-)
>   rename profiles/network/{common.c => bnep.c} (100%)
>   rename profiles/network/{common.h => bnep.h} (100%)
>
> diff --git a/profiles/network/common.c b/profiles/network/bnep.c
> similarity index 100%
> rename from profiles/network/common.c
> rename to profiles/network/bnep.c
> diff --git a/profiles/network/common.h b/profiles/network/bnep.h
> similarity index 100%
> rename from profiles/network/common.h
> rename to profiles/network/bnep.h
> --
  Have you tried to compile after it?

Thanks,
Ravi.

  reply	other threads:[~2013-11-28 19:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-28 14:45 [PATCH_v2 0/7] Refactor bnep code and implement pan methods Ravi kumar Veeramally
2013-11-28 14:45 ` [PATCH_v2 1/7] profiles/network: Remove redundant code for bnep interface name Ravi kumar Veeramally
2013-11-28 15:52   ` Anderson Lizardo
2013-11-28 16:12     ` Luiz Augusto von Dentz
2013-11-28 19:55     ` Ravi kumar Veeramally
2013-11-28 14:45 ` [PATCH_v2 2/7] profiles/network: Refactor bnep connection setup functionality Ravi kumar Veeramally
2013-11-28 14:45 ` [PATCH_v2 3/7] profiles/network: Rename common.c|h to bnep.c|h Ravi kumar Veeramally
2013-11-28 16:19   ` Luiz Augusto von Dentz
2013-11-28 19:52     ` Ravi kumar Veeramally [this message]
2013-11-28 14:45 ` [PATCH_v2 4/7] android/pan: Implement pan connect method in daemon Ravi kumar Veeramally
2013-11-28 14:45 ` [PATCH_v2 5/7] android/pan: Implement pan disconnect " Ravi kumar Veeramally
2013-11-28 14:45 ` [PATCH_v2 6/7] android/pan: Implement the get local role " Ravi kumar Veeramally
2013-11-28 14:45 ` [PATCH_v2 7/7] android: Add reasons for adding capabilites to process Ravi kumar Veeramally

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52979F05.3040803@linux.intel.com \
    --to=ravikumar.veeramally@linux.intel.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.