From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50518) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VmCG1-0002mB-7G for qemu-devel@nongnu.org; Thu, 28 Nov 2013 19:48:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VmCFw-0004ni-Vb for qemu-devel@nongnu.org; Thu, 28 Nov 2013 19:48:33 -0500 Received: from [222.73.24.84] (port=56046 helo=song.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VmCFw-0004ej-9d for qemu-devel@nongnu.org; Thu, 28 Nov 2013 19:48:28 -0500 Message-ID: <5297E3F1.4060200@cn.fujitsu.com> Date: Fri, 29 Nov 2013 08:46:41 +0800 From: Li Guang MIME-Version: 1.0 References: <1385450531-3170-1-git-send-email-lig.fnst@cn.fujitsu.com> <1385450531-3170-4-git-send-email-lig.fnst@cn.fujitsu.com> <5295B9BD.7080101@suse.de> <5295BB1E.1090600@suse.de> In-Reply-To: <5295BB1E.1090600@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 3/4] hw/arm: add sunxi machine type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Andreas_F=E4rber?= Cc: Peter Maydell , Peter Crosthwaite , qemu-devel , Bamvor Jian Zhang Andreas F=E4rber wrote: > Am 27.11.2013 10:22, schrieb Andreas F=E4rber: > =20 >> Hi, >> >> Am 26.11.2013 10:22, schrieb Peter Crosthwaite: >> =20 >>> On Tue, Nov 26, 2013 at 5:22 PM, liguang wrot= e: >>> =20 >>>> Signed-off-by: liguang >>>> --- >>>> hw/arm/Makefile.objs | 1 + >>>> hw/arm/sunxi-soc.c | 98 ++++++++++++++++++++++++++++++++++++++++= ++++++++++ >>>> 2 files changed, 99 insertions(+), 0 deletions(-) >>>> create mode 100644 hw/arm/sunxi-soc.c >>>> >>>> diff --git a/hw/arm/Makefile.objs b/hw/arm/Makefile.objs >>>> index 3671b42..f9f3071 100644 >>>> --- a/hw/arm/Makefile.objs >>>> +++ b/hw/arm/Makefile.objs >>>> @@ -5,3 +5,4 @@ obj-y +=3D tosa.o versatilepb.o vexpress.o xilinx=5Fzy= nq.o z2.o >>>> >>>> obj-y +=3D armv7m.o exynos4210.o pxa2xx.o pxa2xx=5Fgpio.o pxa2xx=5Fp= ic.o >>>> obj-y +=3D omap1.o omap2.o strongarm.o >>>> +obj-y +=3D sunxi-soc.o >>>> diff --git a/hw/arm/sunxi-soc.c b/hw/arm/sunxi-soc.c >>>> new file mode 100644 >>>> index 0000000..b45af6d >>>> --- /dev/null >>>> +++ b/hw/arm/sunxi-soc.c >>>> @@ -0,0 +1,98 @@ >>>> +/* >>>> + * Allwinner sunxi series SoC emulation >>>> + * >>>> + * Copyright (C) 2013 Li Guang >>>> + * Written by Li Guang >>>> + * >>>> + * This program is free software; you can redistribute it and/or modi= fy it >>>> + * under the terms of the GNU General Public License as published by = the >>>> + * Free Software Foundation; either version 2 of the License, or >>>> + * (at your option) any later version. >>>> + * >>>> + * This program is distributed in the hope that it will be useful, bu= t WITHOUT >>>> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY= or >>>> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public Licen= se >>>> + * for more details. >>>> + */ >>>> + >>>> +#include "hw/sysbus.h" >>>> +#include "hw/devices.h" >>>> +#include "hw/boards.h" >>>> +#include "hw/arm/arm.h" >>>> +#include "hw/ptimer.h" >>>> +#include "hw/char/serial.h" >>>> +#include "hw/timer/sunxi-pit.h" >>>> +#include "hw/intc/sunxi-pic.h" >>>> + >>>> +#include "sysemu/sysemu.h" >>>> +#include "exec/address-spaces.h" >>>> + >>>> + >>>> +#define SUNXI=5FPIC=5FREG=5FBASE 0x01c20400 >>>> +#define SUNXI=5FPIT=5FREG=5FBASE 0x01c20c00 >>>> +#define SUNXI=5FUART0=5FREG=5FBASE 0x01c28000 >>>> + >>>> +static struct arm=5Fboot=5Finfo sunxi=5Fbinfo =3D { >>>> + .loader=5Fstart =3D 0x40000000, >>>> + .board=5Fid =3D 0x1008, >>>> +}; >>>> + >>>> +static void sunxi=5Finit(QEMUMachineInitArgs *args) >>>> =20 >>> I would check with Andreas/PMM on what the go is with SoCs regarding >>> container devices and boards. My (vague) understanding is that SoCs >>> should be container devices and boards instantiate those containers >>> with off-chip connectivity. This seems flat to me, with everything on >>> board level. >>> =20 >> Yes, thanks, that matches what I was going to comment. But I think it's >> even more complicated: To my understanding, "sunxi" is the name of a >> community effort [1] to clean up and upstream the BSP kernels from >> Allwinner, so it sounds as if this was an attempt to write an emulation >> for that kernel family while naming everything "sunxi" when in fact the >> SoCs are called Axx [2] (with A1x =3D sun4i, A2x =3D sun5i, A3x =3D sun6= i but >> =20 > My interpolation was incorrect: A10 =3D sun4i, A13 =3D sun5i, A3x =3D sun= 6i, > A20 =3D sun7i > > Andreas > > =20 >> no literal "sunxi" AFAIK) and boards include Cubieboard, Cubieboard2, >> Cubieboard3/Cubietruck [3] and whatever tablets etc. are out there. >> (CC'ing Bamvor) >> >> That's a lesson we learned from the old "prep" machine: Please name >> things after real hardware, only then can it later be verified whether >> the modeling is actually correct or which changes need to be performed. >> >> =20 well, sunxi maybe be representation of Axx series, but, what's wrong? we can't track Axx hardware changes? why? and also, this patch-set is also community effort just like sunxi in linux kernel. >> A practical aspect of modeling SoCs correctly is that they can more >> easily be reused across boards or modules, and you don't need to mess >> with machine-level cpu=5Fmodel if you have a fixed SoC-CPU mapping. >> =20 modeling SoC is good, but sorry, I can't assure that fixed mapping. >> You may want to consult the recent DIGIC or earlier Faraday series or my >> Tegra2 repository for examples of how to implement this paradigm. >> I believe the composition tree naming wrt "cortex" and the MPCore was >> still open, hopefully PMM can comment on his current preferences. >> >> And thanks for your efforts, from a distribution viewpoint I am looking >> forward to testing our kernels and images with this. >> =20 currently, I can only provide linux kernel build for sunxi-4i, where I can up-load it to? >> Regards, >> Andreas >> >> [1] http://linux-sunxi.org/Main=5FPage >> [2] http://www.allwinnertech.com/en/product/A-Serial.html >> =20 this page is can't accessed for me. Thanks for your comment! Li Guang >> [3] http://cubieboard.org/ >> >> =20 > > =20 =