From: Andreas Naumann <dev@andin.de>
To: notasas@gmail.com
Cc: balbi@ti.com, linux-omap@vger.kernel.org
Subject: Re: [PATCH V2] usb: musb: Fix unstable init of OTG_INTERFSEL.
Date: Fri, 29 Nov 2013 09:34:54 +0100 [thread overview]
Message-ID: <529851AE.7090300@andin.de> (raw)
In-Reply-To: <EE4E4767751A8B40949306E403F4DDD80322D479@sv03ultra002.ultratronik.de>
> Nice find, I think I'm also affected by this. However this crashes on
> OMAP3530 pandora because you now access INTERFSEL before interface
> clock is enabled.. This is not a problem on DM37xx because it uses
> different interconnects. You should probably use "context_valid"
> variable in omap2430_glue or similar to decide to write to register or
> not.
>
> Grazvydas
You mean introducing a "context_value"? I'm not sure if i want to add
more code.
Do you think simple removing the first read is an option? So far we read
back 0 anyway because the first write to INTERFSEL in resume() set it to
uninitialized / 0 anyway.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next parent reply other threads:[~2013-11-29 8:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <EE4E4767751A8B40949306E403F4DDD80322D479@sv03ultra002.ultratronik.de>
2013-11-29 8:34 ` Andreas Naumann [this message]
2013-11-29 11:57 ` [PATCH V2] usb: musb: Fix unstable init of OTG_INTERFSEL Grazvydas Ignotas
2013-11-28 7:51 anaumann
[not found] ` <1385625105-7348-1-git-send-email-anaumann-ZKHRqZ6+gQUX0D0ZMPkEVw@public.gmane.org>
2013-11-28 23:35 ` Grazvydas Ignotas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529851AE.7090300@andin.de \
--to=dev@andin.de \
--cc=balbi@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=notasas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.