From: Andrew Cooper <andrew.cooper3@citrix.com>
To: "Liu, Jinsong" <jinsong.liu@intel.com>
Cc: "keir@xen.org" <keir@xen.org>, Jan Beulich <jbeulich@suse.com>,
"Nakajima, Jun" <jun.nakajima@intel.com>,
"tim@xen.org" <tim@xen.org>, "Dong, Eddie" <eddie.dong@intel.com>,
"zhenzhong.duan@oracle.com" <zhenzhong.duan@oracle.com>,
"Dugger, Donald D" <donald.d.dugger@intel.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
"Auld, Will" <will.auld@intel.com>,
"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
"sherry.hurwitz@amd.com" <sherry.hurwitz@amd.com>,
"Zhang, Xiantao" <xiantao.zhang@intel.com>
Subject: Re: [PATCH] VMX: wbinvd when vmentry under UC
Date: Fri, 29 Nov 2013 14:24:40 +0000 [thread overview]
Message-ID: <5298A3A8.6030409@citrix.com> (raw)
In-Reply-To: <DE8DF0795D48FD4CA783C40EC8292335013EF3CD@SHSMSX101.ccr.corp.intel.com>
On 29/11/13 14:15, Liu, Jinsong wrote:
> Jan Beulich wrote:
>>>>> "Liu, Jinsong" <jinsong.liu@intel.com> 11/28/13 8:17 AM >>>
>>> Liu, Jinsong wrote:
>>>> Yes. reprogram_timer here just delay timer a little slot, say,
>>>> 1~2ms. I think it's OK, i.e. at any point of wbinvd() operation at
>>>> hypervisor, or any irq disabled area, timer interrupt in fact also
>>>> has good chance to be delayed some time -- however at TIMER_SOFTIRQ,
>>>> all expired thing would be executed, and re-calculated and set next
>>>> time point via reprogram_timer -- that's OK.
>>> Comments/thoughts about this option?
>> Apart from continuing to be very uncertain that this won't have any
>> bad side effects, I'm also rather concerned that you deal with one
>> special case interrupt here, ignoring other potentially high rate ones
>> (like such coming from NICs).
>>
>> Jan
> Considering this, seems adding flag is the only work around way since high freq interrupt would result in dead-like-loop. My concern of adding flag is it's not easy to clean every possible path, especially future extension.
>
> Or, do not support vt-d w/o snoop.
>
> Thanks,
> Jinsong
Do you know how many systems have vt-d without snoop ?
~Andrew
next prev parent reply other threads:[~2013-11-29 14:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 16:14 [PATCH] VMX: wbinvd when vmentry under UC Liu, Jinsong
2013-11-25 16:39 ` Andrew Cooper
2013-11-25 16:46 ` Jan Beulich
2013-11-25 16:52 ` Auld, Will
2013-11-26 8:56 ` Liu, Jinsong
2013-11-26 9:33 ` Jan Beulich
2013-11-28 7:16 ` Liu, Jinsong
2013-11-28 14:24 ` Jan Beulich
2013-11-29 14:15 ` Liu, Jinsong
2013-11-29 14:24 ` Andrew Cooper [this message]
2013-11-29 14:31 ` Liu, Jinsong
2013-11-29 14:50 ` Andrew Cooper
2013-11-29 15:04 ` Jan Beulich
2013-11-29 14:53 ` Jan Beulich
2013-11-29 16:53 ` Liu, Jinsong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5298A3A8.6030409@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=donald.d.dugger@intel.com \
--cc=eddie.dong@intel.com \
--cc=jbeulich@suse.com \
--cc=jinsong.liu@intel.com \
--cc=jun.nakajima@intel.com \
--cc=keir@xen.org \
--cc=sherry.hurwitz@amd.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=tim@xen.org \
--cc=will.auld@intel.com \
--cc=xen-devel@lists.xen.org \
--cc=xiantao.zhang@intel.com \
--cc=zhenzhong.duan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.