From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59187) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VmRUZ-0008Ax-OT for qemu-devel@nongnu.org; Fri, 29 Nov 2013 12:04:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VmRUU-00016y-TU for qemu-devel@nongnu.org; Fri, 29 Nov 2013 12:04:35 -0500 Message-ID: <5298C919.1020208@suse.de> Date: Fri, 29 Nov 2013 18:04:25 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1385742462-84788-1-git-send-email-petar.jovanovic@rt-rk.com> In-Reply-To: <1385742462-84788-1-git-send-email-petar.jovanovic@rt-rk.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for 1.7] target-mips: fix 64-bit FPU config for user-mode emulation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Petar Jovanovic , qemu-devel@nongnu.org Cc: petar.jovanovic@imgtec.com, aurelien@aurel32.net, qemu-stable Am 29.11.2013 17:27, schrieb Petar Jovanovic: > From: Petar Jovanovic >=20 > FR bit should be initialized to 1 for MIPS64, under condition that this > bit is writable and that CPU has an FPU unit. It should be initialized = to > zero for MIPS32. > This fixes different MIPS32 issues with FPU instructions whose behaviou= r > defaulted to 64-bit FPU mode. >=20 > Signed-off-by: Petar Jovanovic > --- >=20 > A few issues have been raised over the time because this part of the co= de > did the wrong thing for MIPS32. This change is sufficient to fix the > reported issues, such as https://bugs.launchpad.net/qemu/+bug/1233225. > This change does not attempt to cover -mfp64 mode that should be > subject of different yet related change. > We should have this in v1.7 since it is a regression for frequently use= d > QEMU MIPS32 usermode. v1.7.0 has already been released, so it's too late for "for 1.7". Also please prefer "for-x.y" syntax next time, since the space is treated as token delimiter and "for" is not a meaningful token. ;) http://patchwork.ozlabs.org/patch/295442/ What you need instead to get it into the 1.7 stable release is Cc: qemu-stable@nongnu.org in the commit message, to have it backported for v1.7.1. Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg