From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabio M. Di Nitto Date: Fri, 29 Nov 2013 22:39:04 +0100 Subject: [Cluster-devel] [PATCH 2/3] fence_ipmilan: option --method and new option --ipmitool-path In-Reply-To: <602750918.3048711.1385742741085.JavaMail.root@redhat.com> References: <602750918.3048711.1385742741085.JavaMail.root@redhat.com> Message-ID: <52990978.2040406@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 11/29/2013 05:32 PM, Ondrej Mular wrote: > @@ -147,28 +160,44 @@ def define_new_opts(): > all_opt["privlvl"] = { > "getopt" : "P:", > "longopt" : "privlvl", > - "help" : "-P, --privlvl=[level] Privilege level on IPMI device (callback|user|operator|administrator)", > + "help" : "-P, --privlvl=[level] Privilege level on IPMI device (callback|user|operator|administrator)", All the reformatting and cosmetic changes should be in a separate commit. Also, this patch assumes that the first patch you posted is applied to the tree. It's not. Sending incremental patches over patches makes it difficult to rebuild the final binary and test it (yes I have ipmi devices at home :)) Fabio