Re: [xen-unstable test] 22184: regressions - trouble: broken/fail/pass

["Roger Pau Monné" <roger.pau@citrix.com>]

On 30/11/13 04:44, xen.org wrote:
> flight 22184 xen-unstable real [real]
> http://www.chiark.greenend.org.uk/~xensrcts/logs/22184/
> 
> Regressions :-(
> 
> Tests which did not succeed and are blocking,
> including tests which could not be run:
>  test-amd64-amd64-xl-qemuu-winxpsp3  7 windows-install     fail REGR. vs. 22106
>  test-amd64-i386-xl-win7-amd64  9 guest-localmigrate       fail REGR. vs. 22106
> 
> Regressions which are regarded as allowable (not blocking):
>  test-amd64-i386-freebsd10-i386  3 host-install(3)      broken blocked in 22106
> 
> Tests which did not succeed, but are not blocking:
>  test-amd64-i386-freebsd10-amd64  7 freebsd-install             fail never pass

By looking at the logs it seems like if the VG name has '-' on it they 
get replaced to '--' by the device mapper, so the right path should be:

/dev/mapper/lake--frog-freebsd.guest.osstest--disk3

I have a completely untested patch to fix this (I also have to say my 
perl skills are really limited, so probably there's a better way to do 
this):

---
diff --git a/ts-freebsd-install b/ts-freebsd-install
index 470fb83..8b0c7bc 100755
--- a/ts-freebsd-install
+++ b/ts-freebsd-install
@@ -66,8 +66,10 @@ sub prep () {
 			    # Use amd64 as default arch
 			    ? $r{"$gho->{Guest}_arch"} : 'amd64').
 			   ".qcow2.xz");
-				
-    my $rootpartition_dev = "/dev/mapper/$gho->{Vg}-$gho->{Name}--disk3";
+
+    my $vg_mapper = $gho->{Vg};
+    $vg_mapper =~ s/-/--/g;
+    my $rootpartition_dev = "/dev/mapper/$vg_mapper-$gho->{Name}--disk3";
 
     target_cmd_root($ho, "umount $gho->{Lvdev} ||:");