From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH 14/15] staging:iio:ad9832: Mark transfer buffers as __be16
Date: Sat, 30 Nov 2013 11:14:10 +0000 [thread overview]
Message-ID: <5299C882.8020509@kernel.org> (raw)
In-Reply-To: <1385383327-28181-14-git-send-email-lars@metafoo.de>
On 11/25/13 12:42, Lars-Peter Clausen wrote:
> Fixes the following warnings from sparse:
> drivers/staging/iio/frequency/ad9832.c:43:26: warning: incorrect type in assignment (different base types)
> drivers/staging/iio/frequency/ad9832.c:43:26: expected unsigned short [unsigned] [short] <noident>
> drivers/staging/iio/frequency/ad9832.c:43:26: got restricted __be16 [usertype] <noident>
> drivers/staging/iio/frequency/ad9832.c:46:26: warning: incorrect type in assignment (different base types)
> drivers/staging/iio/frequency/ad9832.c:46:26: expected unsigned short [unsigned] [short] <noident>
> drivers/staging/iio/frequency/ad9832.c:46:26: got restricted __be16 [usertype] <noident>
> drivers/staging/iio/frequency/ad9832.c:49:26: warning: incorrect type in assignment (different base types)
> drivers/staging/iio/frequency/ad9832.c:49:26: expected unsigned short [unsigned] [short] <noident>
> drivers/staging/iio/frequency/ad9832.c:49:26: got restricted __be16 [usertype] <noident>
> drivers/staging/iio/frequency/ad9832.c:52:26: warning: incorrect type in assignment (different base types)
> drivers/staging/iio/frequency/ad9832.c:52:26: expected unsigned short [unsigned] [short] <noident>
> drivers/staging/iio/frequency/ad9832.c:52:26: got restricted __be16 [usertype] <noident>
> drivers/staging/iio/frequency/ad9832.c:65:27: warning: incorrect type in assignment (different base types)
> drivers/staging/iio/frequency/ad9832.c:65:27: expected unsigned short [unsigned] [short] <noident>
> drivers/staging/iio/frequency/ad9832.c:65:27: got restricted __be16 [usertype] <noident>
> drivers/staging/iio/frequency/ad9832.c:68:27: warning: incorrect type in assignment (different base types)
> drivers/staging/iio/frequency/ad9832.c:68:27: expected unsigned short [unsigned] [short] <noident>
> drivers/staging/iio/frequency/ad9832.c:68:27: got restricted __be16 [usertype] <noident>
> drivers/staging/iio/frequency/ad9832.c:107:26: warning: incorrect type in assignment (different base types)
> drivers/staging/iio/frequency/ad9832.c:107:26: expected unsigned short [unsigned] data
> drivers/staging/iio/frequency/ad9832.c:107:26: got restricted __be16 [usertype] <noident>
> drivers/staging/iio/frequency/ad9832.c:120:26: warning: incorrect type in assignment (different base types)
> drivers/staging/iio/frequency/ad9832.c:120:26: expected unsigned short [unsigned] data
> drivers/staging/iio/frequency/ad9832.c:120:26: got restricted __be16 [usertype] <noident>
> drivers/staging/iio/frequency/ad9832.c:133:26: warning: incorrect type in assignment (different base types)
> drivers/staging/iio/frequency/ad9832.c:133:26: expected unsigned short [unsigned] data
> drivers/staging/iio/frequency/ad9832.c:133:26: got restricted __be16 [usertype] <noident>
> drivers/staging/iio/frequency/ad9832.c:144:26: warning: incorrect type in assignment (different base types)
> drivers/staging/iio/frequency/ad9832.c:144:26: expected unsigned short [unsigned] data
> drivers/staging/iio/frequency/ad9832.c:144:26: got restricted __be16 [usertype] <noident>
> drivers/staging/iio/frequency/ad9832.c:277:18: warning: incorrect type in assignment (different base types)
> drivers/staging/iio/frequency/ad9832.c:277:18: expected unsigned short [unsigned] data
> drivers/staging/iio/frequency/ad9832.c:277:18: got restricted __be16 [usertype] <noident>
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Applied to the togreg branch of iio.git
Thanks,
> ---
> drivers/staging/iio/frequency/ad9832.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/iio/frequency/ad9832.h b/drivers/staging/iio/frequency/ad9832.h
> index c5b701f..386f4dc 100644
> --- a/drivers/staging/iio/frequency/ad9832.h
> +++ b/drivers/staging/iio/frequency/ad9832.h
> @@ -92,9 +92,9 @@ struct ad9832_state {
> * transfer buffers to live in their own cache lines.
> */
> union {
> - unsigned short freq_data[4]____cacheline_aligned;
> - unsigned short phase_data[2];
> - unsigned short data;
> + __be16 freq_data[4]____cacheline_aligned;
> + __be16 phase_data[2];
> + __be16 data;
> };
> };
>
>
next prev parent reply other threads:[~2013-11-30 11:14 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 12:41 [PATCH 01/15] iio:ad5504: Mark transfer buffers as __be16 Lars-Peter Clausen
2013-11-25 12:41 ` [PATCH 02/15] iio:ad5504: Do not store transfer buffers on the stack Lars-Peter Clausen
2013-11-30 11:07 ` Jonathan Cameron
2013-11-25 12:41 ` [PATCH 03/15] iio:ad5421: Mark transfer buffer as __be32 Lars-Peter Clausen
2013-11-30 11:07 ` Jonathan Cameron
2013-11-25 12:41 ` [PATCH 04/15] iio:ad5686: " Lars-Peter Clausen
2013-11-30 11:07 ` Jonathan Cameron
2013-11-25 12:41 ` [PATCH 05/15] iio:ad5755: " Lars-Peter Clausen
2013-11-30 11:08 ` Jonathan Cameron
2013-11-25 12:41 ` [PATCH 06/15] iio:ad5791: Mark transfer buffers " Lars-Peter Clausen
2013-11-30 11:08 ` Jonathan Cameron
2013-11-25 12:41 ` [PATCH 07/15] iio:ad5791: Do not store transfer buffers on the stack Lars-Peter Clausen
2013-11-30 11:09 ` Jonathan Cameron
2013-12-22 17:36 ` Jonathan Cameron
2013-12-22 17:40 ` Lars-Peter Clausen
2013-12-22 17:43 ` Jonathan Cameron
2013-11-25 12:42 ` [PATCH 08/15] iio:ad7266: Mark transfer buffer as __be16 Lars-Peter Clausen
2013-11-30 11:10 ` Jonathan Cameron
2013-11-25 12:42 ` [PATCH 09/15] iio:vcnl4000: " Lars-Peter Clausen
2013-11-30 11:11 ` Jonathan Cameron
2013-11-25 12:42 ` [PATCH 10/15] staging:iio:ad7280a: Mark transfer buffer as __be32 Lars-Peter Clausen
2013-11-30 11:12 ` Jonathan Cameron
2013-11-25 12:42 ` [PATCH 11/15] staging:iio:ad7280a: Do not store transfer buffer on the stack Lars-Peter Clausen
2013-11-30 11:12 ` Jonathan Cameron
2013-11-25 12:42 ` [PATCH 12/15] staging:iio:ad7746: Mark transfer buffer as __be32 Lars-Peter Clausen
2013-11-30 11:13 ` Jonathan Cameron
2013-11-25 12:42 ` [PATCH 13/15] staging:iio:ad7746: Do not store the transfer buffer on the stack Lars-Peter Clausen
2013-11-30 11:13 ` Jonathan Cameron
2013-12-22 17:22 ` Jonathan Cameron
2013-11-25 12:42 ` [PATCH 14/15] staging:iio:ad9832: Mark transfer buffers as __be16 Lars-Peter Clausen
2013-11-30 11:14 ` Jonathan Cameron [this message]
2013-12-03 10:27 ` Lars-Peter Clausen
2013-12-03 14:56 ` Jonathan Cameron
2013-12-03 20:09 ` Jonathan Cameron
2013-12-03 20:11 ` Lars-Peter Clausen
2013-11-25 12:42 ` [PATCH 15/15] staging:iio:ad9834: Mark transfer buffers as __b16 Lars-Peter Clausen
2013-11-30 11:14 ` Jonathan Cameron
2013-11-30 11:03 ` [PATCH 01/15] iio:ad5504: Mark transfer buffers as __be16 Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5299C882.8020509@kernel.org \
--to=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.