From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56405) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VmkIJ-0006LM-6N for qemu-devel@nongnu.org; Sat, 30 Nov 2013 08:09:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VmkIB-00033z-Tt for qemu-devel@nongnu.org; Sat, 30 Nov 2013 08:09:11 -0500 Received: from mail-pb0-f52.google.com ([209.85.160.52]:35503) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VmkIB-00033q-Nl for qemu-devel@nongnu.org; Sat, 30 Nov 2013 08:09:03 -0500 Received: by mail-pb0-f52.google.com with SMTP id uo5so15829523pbc.25 for ; Sat, 30 Nov 2013 05:09:02 -0800 (PST) Message-ID: <5299E368.1040109@ozlabs.ru> Date: Sun, 01 Dec 2013 00:08:56 +1100 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1384155875-26999-1-git-send-email-aik@ozlabs.ru> <1384155875-26999-2-git-send-email-aik@ozlabs.ru> <5299B992.3060906@ozlabs.ru> <5299C561.7010101@redhat.com> In-Reply-To: <5299C561.7010101@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 1/6] cpu: add suboptions support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , Alexander Graf On 11/30/2013 10:00 PM, Paolo Bonzini wrote: > Il 30/11/2013 11:10, Alexey Kardashevskiy ha scritto: >> btw there is a problem - all this qemu_opt stuff normally lives in vl.c so >> this patch does not compile with linux-user target. > > Which qemu_opt exactly? > > Perhaps you can just move it to util/qemu-option.c or something like that. Hm. Doublechecked. I copied qemu_get_cpu_opts() from qemu_get_machine_opts() and put it in vl.c but it can perfectly live in qom/cpu.c along with cpu_default_parse_options_func() and others. Thanks for the hint. > > Paolo > >> How to solve this properly before I continue spamming the list? :) >> > -- Alexey