Re: [PATCH 2/3 v3] usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello.

On 30-11-2013 7:51, Chris Ruehl wrote:

> usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag

> * init the sts flag to 0 (missed)
> * Set PORTCS_STS only if VUSB_HS_PHY_TYPE > 1
>    otherwise the register is ReadOnly
> * Set/Reset correct BIT(28)/BIT(29) for STS

> Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>

    The coding style is still wrong at places...

> diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
> index 5075407..2c634c1 100644
> --- a/drivers/usb/chipidea/core.c
> +++ b/drivers/usb/chipidea/core.c
[...]
> @@ -273,10 +273,24 @@ static void hw_phymode_configure(struct ci_hdrc *ci)
>
>   	if (ci->hw_bank.lpm) {
>   		hw_write(ci, OP_DEVLC, DEVLC_PTS(7) | DEVLC_PTW, lpm);
> -		hw_write(ci, OP_DEVLC, DEVLC_STS, sts);
> +		if ( sts )

    Remove spaces around 'sts', please.

> +			hw_write(ci, OP_DEVLC, DEVLC_STS, BIT(28));
> +		else
> +			hw_write(ci, OP_DEVLC, DEVLC_STS, ~BIT(28));
>   	} else {
>   		hw_write(ci, OP_PORTSC, PORTSC_PTS(7) | PORTSC_PTW, portsc);
> -		hw_write(ci, OP_PORTSC, PORTSC_STS, sts);
> +		if (((portsc >> 30) & 0x3) > 1) {
> +			if (sts) {
> +				hw_write(ci, OP_PORTSC, PORTSC_STS, BIT(29));
> +			}
> +			else {

			} else {

> +				portsc = (ioread32(ci->hw_bank.regmap[OP_PORTSC])
> +						& PORTSC_STS);

    No need for outer (). And it's preferred that an operator is left at the 
end of a first line, not starts the continuation line.

WBR, Sergei