From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH 00/13] Coverity fixes for libxl Date: Sun, 1 Dec 2013 12:22:30 +0000 Message-ID: <529B2A06.9030402@citrix.com> References: <1385892907-20084-1-git-send-email-mattd@bugfuzz.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1385892907-20084-1-git-send-email-mattd@bugfuzz.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Matthew Daley , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 01/12/2013 10:14, Matthew Daley wrote: All except for patches 4 and 8 (which have followups), Reviewed-by: Andrew Cooper > Matthew Daley (13): > libxl: fix unsigned less-than-0 comparison in e820_sanitize > libxl: check for xc_domain_setmaxmem failure in libxl__build_pre > libxl: correct file open success check in libxl__device_pci_reset > libxl: don't leak p in libxl__wait_for_backend > libxl: remove unsigned less-than-0 comparison > libxl: actually abort if initializing a ctx's lock fails > libxl: don't leak output vcpu info on error in libxl_list_vcpu > libxl: don't leak ptr in libxl_list_vm error case > libxl: don't leak pcidevs in libxl_pcidev_assignable > libxl: don't try to fclose file twice on error in > libxl_userdata_store > libxl: use pipe instead of temporary file for VNC viewer --autopass > libxl: don't leak buf in libxl_xen_console_read_start error handling > libxl: replace for loop with more idiomatic do-while loop > > tools/libxl/libxl.c | 64 +++++++++++++++++++++----------------------- > tools/libxl/libxl_cpuid.c | 2 +- > tools/libxl/libxl_device.c | 3 +++ > tools/libxl/libxl_dom.c | 42 ++++++++++++++--------------- > tools/libxl/libxl_pci.c | 9 +++---- > tools/libxl/libxl_x86.c | 2 +- > 6 files changed, 59 insertions(+), 63 deletions(-) >