From: Amir Vadai <amirv.mellanox@gmail.com>
To: Tom Herbert <therbert@google.com>,
netdev@vger.kernel.org, davem@davemloft.net
Cc: Hadar Hen Zion <hadarh@mellanox.com>
Subject: Re: [PATCH v2 13/17] net: mlx4 calls skb_set_rxhash
Date: Sun, 01 Dec 2013 14:26:31 +0200 [thread overview]
Message-ID: <529B2AF7.90309@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1311260928050.21143@tomh.mtv.corp.google.com>
On 26/11/2013 19:31, Tom Herbert wrote:
> Drivers should call skb_set_rxhash to set the rxhash and its type
> in an skbuff.
>
> Signed-off-by: Tom Herbert <therbert@google.com>
> ---
> drivers/net/ethernet/mellanox/mlx4/en_rx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx4/en_rx.c b/drivers/net/ethernet/mellanox/mlx4/en_rx.c
> index 07a1d0f..3e48c44 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/en_rx.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/en_rx.c
> @@ -747,7 +747,7 @@ int mlx4_en_process_rx_cq(struct net_device *dev, struct mlx4_en_cq *cq, int bud
> }
>
> if (dev->features & NETIF_F_RXHASH)
> - gro_skb->rxhash = be32_to_cpu(cqe->immed_rss_invalid);
> + skb_set_rxhash(gro_skb, be32_to_cpu(cqe->immed_rss_invalid), RXHASH_TYPE_L3);
>
> skb_record_rx_queue(gro_skb, cq->ring);
>
> @@ -789,7 +789,7 @@ int mlx4_en_process_rx_cq(struct net_device *dev, struct mlx4_en_cq *cq, int bud
> skb_record_rx_queue(skb, cq->ring);
>
> if (dev->features & NETIF_F_RXHASH)
> - skb->rxhash = be32_to_cpu(cqe->immed_rss_invalid);
> + skb_set_rxhash(skb, be32_to_cpu(cqe->immed_rss_invalid), RXHASH_TYPE_L3);
>
> if ((be32_to_cpu(cqe->vlan_my_qpn) &
> MLX4_CQE_VLAN_PRESENT_MASK) &&
>
I need to do some work in this area of code, but anyway it is not in the
scope of this patchset.
Acked-By: Amir Vadai <amirv@mellanox.com>
prev parent reply other threads:[~2013-12-01 12:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-26 17:31 [PATCH v2 13/17] net: mlx4 calls skb_set_rxhash Tom Herbert
2013-12-01 12:26 ` Amir Vadai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529B2AF7.90309@gmail.com \
--to=amirv.mellanox@gmail.com \
--cc=davem@davemloft.net \
--cc=hadarh@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.